-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for node_pools #331
Closed
neelesh9795
wants to merge
166
commits into
terraform-google-modules:master
from
neelesh9795:feature/node-pool
Closed
Changes from 14 commits
Commits
Show all changes
166 commits
Select commit
Hold shift + click to select a range
e8688fc
Initial definition of a Safer Cluster module.
mmontan f63e69b
Merge branch 'master' into safer-cluster
morgante 599dd2e
Initial definition of a Safer Cluster module.
mmontan d60fb28
Merge branch 'safer-cluster' of github.com:mmontan/terraform-google-k…
mmontan 23dc5cf
Merge pull request #1 from terraform-google-modules/master
bharathkkb d969d86
add private_zonal_with_networking example
ideasculptor c3d6536
get gke module to wait on network creation correctly
ideasculptor 23bfac9
Get tests for private_zonal_with_network to function correctly
ideasculptor 1e1ed91
lint fix
ideasculptor 366b5cb
Merge remote-tracking branch 'upstreamz/master'
bharathkkb 3e12560
Merge remote-tracking branch 'mmontan/safer-cluster' into feature/gke…
bharathkkb b3a6d3e
add shielded vms, use new CI, address comments
bharathkkb 31f833b
adds docs from PR281, add desc
bharathkkb 6f7de18
Merge branch 'master' into feature/gke-safe-cluster
2c1aa19
Initial definition of a Safer Cluster module.
mmontan b411371
add shielded vms, use new CI, address comments
bharathkkb 8539316
adds docs from PR281, add desc
bharathkkb 5a19471
address comments
bharathkkb afda7fe
address comments
bharathkkb fb38612
fix lint
bharathkkb 62418d0
Example to create private cluster with node pool specifications along…
alekhyal 9370965
Terraform fmt and default values are removed
alekhyal 1ca8f82
Fixed lint issues
alekhyal 1120377
Merge branch 'master' into feature/gke-safe-cluster
1a5eb63
add types, fix desc
bharathkkb 13bd082
Merge pull request #1 from terraform-google-modules/master
neelesh9795 ac3b601
Updated node_pools variable documentation
neelesh9795 f6a1fe7
Added tables to the documentation
neelesh9795 271fc6a
Made changes to the variables
neelesh9795 4600b98
Added the autoscaling property
neelesh9795 56353d6
Default column added
neelesh9795 45f6ac8
Default column added
neelesh9795 b8b4e7c
Made changes to the table
neelesh9795 82217de
Added node_locations
neelesh9795 9c5983d
Updated auto upgrade
neelesh9795 c8bcfaa
node count added
neelesh9795 f466f0d
doubled the timeout in .kitchen.yml
alekhyal fdfa88c
changing the timeout value
alekhyal 2d996f6
Merge branch 'master' into feature/gke-safe-cluster
b18a5df
Fixed Errors
neelesh9795 2ae6c27
Fixed Errors
neelesh9795 4aa670f
Fixed Errors
neelesh9795 5fc8185
Merge branch 'master' into master
9b821bf
addressed comments made for regional_private_node_pool example
alekhyal 0bffa5c
Merge branch 'master' of github.com:alekhyal/terraform-google-kuberne…
alekhyal be5e130
Merge pull request #2 from terraform-google-modules/master
bharathkkb 9b2fa14
add .tmpl ext to autogen tf templates
bharathkkb 7e9e119
remove random file generated during testing
bharathkkb 85c3e3f
pylint
bharathkkb 03ed750
Removed kubernetes dashboard add config.
Shashindran 86b3dd6
Merge pull request #1 from Shashindran/Shashindran-patch-1
Shashindran c7ec3a9
Update outputs.tf
Shashindran 465b7c7
Update main.tf
Shashindran 591b9a9
Updated autogen to remove the inclusion of kubernetes dashboard addon.
034d7e8
Removed kubernets dashboard addon from all modules.
d27cc7a
Merge pull request #335 from bharathkkb/feature/fix-templating
morgante 2124137
Merge pull request #310 from ideasculptor/private_zonal_example
morgante 02f24dd
Add dependency to 'wait for resource'
jantoebes 8e6df72
Add dependency to 'wait for resource'
jantoebes 868eecd
Add support for local_ssd_count in node config.
842629b
Merge pull request #339 from terraform-google-modules/feature/local-s…
morgante 0874606
Merge pull request #340 from jantoebes/cluster-wait-for-resource
morgante 3c7f472
Update CHANGELOG.md
morgante bf48602
Make node_pools_* params optional and allow pool-specific overrides.
cray0000 1d8b42a
Merge branch 'master' into feature/gke-safe-cluster
bharathkkb 2d650a1
Changes to the variables
neelesh9795 d86c8ac
Merge branch 'feature/node-pool' of https://github.com/neelesh9795/te…
neelesh9795 5fca169
Fixed the files and updated README.
Shashindran 566648c
Merge remote-tracking branch 'upstream/master'
Shashindran 6fc8854
Updated README and variables.tf
Shashindran 1e21211
Added cluster autoscaling
kopachevsky fbc2604
Merge pull request #318 from cray0000/f-make-params-optional
0468ec7
Merge branch 'master' into feature/gke-safe-cluster
f026f64
Merge branch 'master' into master
598ea5b
formatted outputs.tf file
alekhyal a8e6fe2
Merge branch 'master' of github.com:alekhyal/terraform-google-kuberne…
alekhyal 0ae6777
Merge pull request #337 from Shashindran/master
morgante 63c8b6f
Update CHANGELOG.md
morgante 0dc2698
Merge branch 'master' into master
e5a7267
Merge pull request #3 from terraform-google-modules/master
bharathkkb d1098b5
Fixes #180: Add tests for beta submodules/examples
bohdanyurov-gl 8a135fe
Merge branch 'master' into feature/gke-safe-cluster
1f2edb6
remove kubernetes_dashboard_enabled
bharathkkb 4f3df80
Remove obsolete dashboard output
509f6ba
fix int test
bharathkkb 4d220a2
Merge pull request #321 from alekhyal/master
6b0e4f0
Merge pull request #4 from terraform-google-modules/master
bharathkkb 191e16b
Merge branch 'master' into feature/gke-safe-cluster
bharathkkb 932bd0e
hardcode vars
bharathkkb ee1593f
Updated "upstream_nameservers" variable type to list(string)
rbramwell 98d3697
Updated docs via autogen
rbramwell 0290261
Merge pull request #350 from rbramwell/update_upstream_nameservers_va…
morgante 04fcb50
Added cluster autoscaling - optimized input variable
kopachevsky b06c425
update int test to split between two projects
bharathkkb 0be30c8
fix outputs
bharathkkb 5564e1b
Merge branch 'master' into feature/gke-safe-cluster
bharathkkb 2b7ef3d
Merge pull request #315 from bharathkkb/feature/gke-safe-cluster
7def757
Add multiple issues to CHANGELOG
1c5f826
Merge branch 'master' into issues/93/cluster_autoscaling
d856f2b
Remove trailing whitespace from CHANGELOG
1bd6557
Merge branch 'master' into issues/93/cluster_autoscaling
a19bd31
Merge pull request #5 from terraform-google-modules/master
bharathkkb 45cd949
Merge pull request #328 from kopachevsky/issues/93/cluster_autoscaling
c61e893
Add #93 to CHANGELOG
8309664
Remove make_source.sh. Outputs are automatically piped to kitchen_do
cray0000 5b08b91
Merge pull request #353 from terraform-google-modules/remove-make-source
morgante 94496f9
Simplify master_authorized_networks_config to master_authorized_networks
morgante e92a99a
Start v6.0 upgrade guide
morgante dd81751
add k8s note to upgrade doc
morgante 3d23898
Fix terraform fmt
morgante 152ff2e
Merge pull request #354 from terraform-google-modules/feature/simplif…
1cc42d0
Merge pull request #6 from terraform-google-modules/master
bharathkkb c7787f2
enable network_policy by default, fix examples
bharathkkb 2abd7b4
check for network policy enabled instead of disabled in kitchen tests
bharathkkb 1d8356d
Merge pull request #356 from bharathkkb/feature/default-enable-networ…
d780442
Remove upgrade notes from CHANGELOG
97529bc
Add #354, 6.0.0 to CHANGELOG
d426a1e
Add #138 to CHANGELOG
cfbdefc
Merge branch 'master' into fix/180
13a08a4
Update beta_cluster project configuration
da4ad51
Fix check for network policy config
27786a6
Merge pull request #219 from bohdanyurov-gl/fix/180
9a4ca42
Merge branch 'master' into aaron-lane-6.0.0
morgante 7ec9c08
Add more detailed documentation for private cluster connectivity.
morgante 8ad1634
Amend master authorized docs
morgante ca6e16c
Regenerate docs
morgante 5161780
Merge pull request #323 from terraform-google-modules/docs/private-cl…
morgante b57db96
Merge pull request #355 from terraform-google-modules/aaron-lane-6.0.0
morgante 4ea7584
Update CHANGELOG.md
morgante 11797c4
Add variable to allow a pre-generated SSH key to be passed to the ACM…
paulpalamarchuk 509afe6
Relax provider version constraint
morgante 0c10e94
Merge pull request #361 from terraform-google-modules/bugfix/version
aaron-lane 45a8e33
Add #359, v6.0.1 to CHANGELOG
aaron-lane 39e93a6
Merge branch 'master' into add_var_to_pass_ssh-key_in_acm
aaron-lane c3b8fcd
Compute region output for zonal clusters
morgante dfeca1b
Merge branch 'master' into bugfix/zonal-region
morgante 19015da
Merge pull request #346 from paulpalamarchuk/add_var_to_pass_ssh-key_…
morgante 85f706d
Update CHANGELOG.md
morgante 01712fa
Fix typo
morgante 9132bbe
Update CHANGELOG.md
morgante e11a822
Merge branch 'master' into bugfix/zonal-region
aaron-lane bcc0960
Merge pull request #362 from terraform-google-modules/bugfix/zonal-re…
morgante 5bc7419
Update CHANGELOG.md
morgante 2283032
Update CHANGELOG.md
morgante 97cde19
Added beta clusters conditionals
neelesh9795 7b10db3
Updated node_pools variable documentation
neelesh9795 515e552
Added tables to the documentation
neelesh9795 2db2c4d
Made changes to the variables
neelesh9795 6d428e7
Added the autoscaling property
neelesh9795 afbc5ec
Default column added
neelesh9795 9df34fb
Default column added
neelesh9795 93e8e7c
Made changes to the table
neelesh9795 62963c1
Added node_locations
neelesh9795 24cad17
Updated auto upgrade
neelesh9795 363d850
node count added
neelesh9795 6e609f1
Fixed Errors
neelesh9795 73f788a
Fixed Errors
neelesh9795 34838b0
Fixed Errors
neelesh9795 c2e3b04
Changes to the variables
neelesh9795 e1bf73e
Added beta clusters conditionals
neelesh9795 692450d
Removing Conflicts
neelesh9795 05944ac
Merge branch 'feature/node-pool' of https://github.com/neelesh9795/te…
neelesh9795 bb8da13
Fixed Errors
neelesh9795 c842a09
Resolved merge conflicts
neelesh9795 6dc75a2
Fixed Errors
neelesh9795 5741cea
Merge branch 'feature/node-pool' of https://github.com/neelesh9795/te…
neelesh9795 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,6 +185,27 @@ In order to operate with the Service Account you must activate the following API | |
- Compute Engine API - compute.googleapis.com | ||
- Kubernetes Engine API - container.googleapis.com | ||
|
||
## node_pools variable | ||
The node_pools variable takes the following parameters: | ||
|
||
| Name | Description | Default | Requirement | | ||
| --- | --- | --- | --- | | ||
| auto_repair | Whether the nodes will be automatically repaired | true | Optional | | ||
| autoscaling | Configuration required by cluster autoscaler to adjust the size of the node pool to the current cluster usage | true | Optional | | ||
| auto_upgrade | Whether the nodes will be automatically upgraded | true (if cluster is regional) | Optional | | ||
| disk_size_gb | Size of the disk attached to each node, specified in GB. The smallest allowed disk size is 10GB | 100GB | Optional | | ||
| disk_type | Type of the disk attached to each node (e.g. 'pd-standard' or 'pd-ssd') | pd-standard | Optional | | ||
| image_type | The image type to use for this node. Note that changing the image type will delete and recreate all nodes in the node pool | COS | Optional | | ||
| initial_node_count | The initial number of nodes for the pool. In regional or multi-zonal clusters, this is the number of nodes per zone. Changing this will force recreation of the resource | 0 | Optional | | ||
| machine_type | The name of a Google Compute Engine machine type | n1-standard-2 | Optional | | ||
| max_count | Maximum number of nodes in the NodePool. Must be >= min_count | 100 | Optional | | ||
| min_count | Minimum number of nodes in the NodePool. Must be >=0 and <= max_count | 1 | Optional | | ||
| name | The name of the node pool | " " | Optional | | ||
| node_count | The number of nodes in the nodepool when autoscaling is false | 2 | Required (when autoscaling is false) | | ||
| node_locations | The list of zones in which the cluster's nodes are located. Nodes must be in the region of their regional cluster or in the same region as their cluster's zone for zonal clusters | " " | Optional | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is only available on beta clusters, please make sure to only include beta features inside beta conditionals: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/cluster.tf.tmpl#L321 |
||
| preemptible | A boolean that represents whether or not the underlying node VMs are preemptible | false | Optional | | ||
| service_account | The service account to be used by the Node VMs | " " | Optional | | ||
|
||
## File structure | ||
The project has the following folders and files: | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required.