Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set initial_node_count when autoscaling disabled on node pool #313

Conversation

taylorludwig
Copy link
Contributor

Fixes #311

When autoscaling is false for a node pool only node_count should be set. initial_node_count should be empty.

Also uses a new node pool var node_count rather than using min_count to match the provider vars. #297 should be updated to include this (defaults to 1).

A node pool without autoscaling can be created with

{
    autoscaling = false
    node_count = 2 
    ...
}

…m-google-modules#311

Dont set initial_node_count when autoscaling is disabled on node pool.
Use new node pool var  when setting desired size of pool - matches provider var
@taylorludwig taylorludwig changed the title Don't set initial_node_count when autoscaling disabled on node pool #311 Don't set initial_node_count when autoscaling disabled on node pool Nov 9, 2019
@aaron-lane aaron-lane added the bug Something isn't working label Nov 11, 2019
aaron-lane
aaron-lane previously approved these changes Nov 11, 2019
after merging with master us-east4 maxes out default quota of 72 cpus in the region
@aaron-lane aaron-lane merged commit 36e9226 into terraform-google-modules:master Nov 13, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…fix/311-autoscaling_node_count

Don't set initial_node_count when autoscaling disabled on node pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initial_node_count and node_count both set when node pool autoscaling is disabled
2 participants