feat: Logging and Snapshot copy resources converted to standalone resource equivalents, MSV of Terraform raised to v1.3
#99
Conversation
|
|
||
| ```bash | ||
| terraform import 'module.redshift.aws_redshift_logging.this[0]' <cluster-id> | ||
| terraform import 'module.redshift.aws_redshift_snapshot_copy.this[0]' <cluster-id> |
There was a problem hiding this comment.
For those who have snapshot_copy previously configured, this will require an import or it will produce an error that snapshot copy is already enabled when it attempts to create the new resource. I don't mind removing this guide but just want to confirm that we don't want to consider this a breaking change.
╷
│ Error: creating Amazon Redshift Snapshot Copy ("ex-complete"): operation error Redshift: EnableSnapshotCopy, https response error StatusCode: 400, RequestID: caf48715-ac18-4a26-9b28-5c8b647cc5e7, SnapshotCopyAlreadyEnabledFault: Snapshot Copy is already enabled on Cluster ex-complete
│
│ with module.redshift.aws_redshift_snapshot_copy.this[0],
│ on ../../main.tf line 321, in resource "aws_redshift_snapshot_copy" "this":
│ 321: resource "aws_redshift_snapshot_copy" "this" {
│
│ operation error Redshift: EnableSnapshotCopy, https response error StatusCode: 400, RequestID: caf48715-ac18-4a26-9b28-5c8b647cc5e7, SnapshotCopyAlreadyEnabledFault: Snapshot Copy is already enabled on Cluster ex-complete
╵
There was a problem hiding this comment.
I see. I thought these resources had the same adoptable behavior as S3 bucket resources like "logging," "versioning," etc. Thank you for the explanation.
|
|
||
| ```bash | ||
| terraform import 'module.redshift.aws_redshift_logging.this[0]' <cluster-id> | ||
| terraform import 'module.redshift.aws_redshift_snapshot_copy.this[0]' <cluster-id> |
There was a problem hiding this comment.
I see. I thought these resources had the same adoptable behavior as S3 bucket resources like "logging," "versioning," etc. Thank you for the explanation.
Co-authored-by: Anton Babenko <[email protected]>
|
Bumped terraform MSV to 1.3. 👍 |
bryantbiggs
changed the title
v1.3
## [5.5.0](v5.4.0...v5.5.0) (2024-05-08) ### Features * Logging and Snapshot copy resources converted to standalone resource equivalents, MSV of Terraform raised to `v1.3` ([#99](#99)) ([2a2fbdc](2a2fbdc))
|
This PR is included in version 6.0.0 🎉 |
|
crap - started editing title in one window and then switched to a different window - should have been 
I've removed the |
|
Ah, my bad. I was wondering what |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add
aws_redshift_loggingandaws_redshift_snapshot_copyresources and removed deprecated configuration blocks foraws_redshift_cluster.loggingandaws_redshift_cluster.snapshot_copy.Motivation and Context
hashicorp/terraform-provider-aws#36862
hashicorp/terraform-provider-aws#36810
Breaking Changes
Yes. New logging and snapshot copy resources replace existing deprecated
loggingandsnapshot_copyblocks inaws_redshift_cluster.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request