Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logging and Snapshot copy resources converted to standalone resource equivalents, MSV of Terraform raised to
v1.3
#99feat: Logging and Snapshot copy resources converted to standalone resource equivalents, MSV of Terraform raised to
v1.3
#99Changes from all commits
570363a
a73768c
a62dda3
bbe6a64
788ed14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those who have
snapshot_copy
previously configured, this will require an import or it will produce an error that snapshot copy is already enabled when it attempts to create the new resource. I don't mind removing this guide but just want to confirm that we don't want to consider this a breaking change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I thought these resources had the same adoptable behavior as S3 bucket resources like "logging," "versioning," etc. Thank you for the explanation.