r/aws_redshift_logging: new resource #36862

jar-b · 2024-04-11T16:05:46Z

Description

This resource will allow practitioners to manage Amazon Redshift cluster logging configurations with Terraform. This standalone resource will replace the optional logging block within the aws_redshift_cluster resource, allowing logging configurations to be managed independent of the parent cluster.

The logging argument within the aws_redshift_cluster resource is now deprecated.

Relations

Closes #36651

References

Output from Acceptance Testing

% make testacc PKG=redshift TESTS=TestAccRedshiftLogging_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftLogging_'  -timeout 360m

--- PASS: TestAccRedshiftLogging_disappears_Cluster (411.73s)
--- PASS: TestAccRedshiftLogging_basic (425.21s)
--- PASS: TestAccRedshiftLogging_disappears (437.79s)
--- PASS: TestAccRedshiftLogging_s3 (522.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   528.588s

This resource will allow practitioners to manage Amazon Redshift cluster logging configurations with Terraform. This standalone resource will replace the optional `logging` block within the `aws_redshift_cluster` resource, allowing logging configurations to be managed independent of the parent cluster. ```console % make testacc PKG=redshift TESTS=TestAccRedshiftLogging_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftLogging_' -timeout 360m --- PASS: TestAccRedshiftLogging_disappears_Cluster (411.73s) --- PASS: TestAccRedshiftLogging_basic (425.21s) --- PASS: TestAccRedshiftLogging_disappears (437.79s) --- PASS: TestAccRedshiftLogging_s3 (522.88s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 528.588s ```

github-actions · 2024-04-11T16:06:00Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

This argument is deprecated in favor of the new, standalone `aws_redshift_logging` resource.

gdavison

A few comments on the id parameter and basic tests. The basic test isn't a blocker. Otherwise looks good.

--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (387.37s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (398.85s)
--- PASS: TestAccRedshiftCluster_kmsKey (425.40s)
--- PASS: TestAccRedshiftCluster_disappears (430.00s)
--- PASS: TestAccRedshiftCluster_basic (433.48s)
--- PASS: TestAccRedshiftCluster_iamRoles (439.29s)
--- PASS: TestAccRedshiftLogging_disappears (442.28s)
--- FAIL: TestAccRedshiftCluster_snapshotCopy (445.79s)
--- PASS: TestAccRedshiftCluster_loggingEnabled (470.11s)
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (492.94s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (534.20s)
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (548.49s)
--- PASS: TestAccRedshiftCluster_tags (591.88s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (735.42s)
--- PASS: TestAccRedshiftLogging_basic (424.98s)
--- PASS: TestAccRedshiftCluster_forceNewUsername (846.46s)
--- PASS: TestAccRedshiftLogging_s3 (424.41s)
--- PASS: TestAccRedshiftLogging_disappears_Cluster (420.53s)
--- PASS: TestAccRedshiftCluster_manageMasterPassword (419.58s)
--- PASS: TestAccRedshiftCluster_aqua (441.84s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (886.18s)
--- PASS: TestAccRedshiftCluster_publiclyAccessible (444.93s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshotARN (943.72s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (1004.78s)
--- PASS: TestAccRedshiftCluster_changeEncryption1 (1201.45s)
--- PASS: TestAccRedshiftCluster_multiAZ (831.77s)
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1303.53s)
--- PASS: TestAccRedshiftCluster_updateNodeCount (1266.56s)
--- PASS: TestAccRedshiftCluster_updateNodeType (1447.71s)

TestAccRedshiftCluster_snapshotCopy is an intermittent failure

gdavison · 2024-04-11T17:42:32Z

internal/service/redshift/logging.go

+	if resp.Diagnostics.HasError() {
+		return
+	}
+	plan.ID = types.StringValue(plan.ClusterIdentifier.ValueString())


id is redundant, since it's the same as cluster_identifier, so it's not needed for a Framework-based resource

Chatted offline on this topic. Will leave the id attribute for now until we decide on a standard across the provider for Terraform Plugin Framework-based resources.

gdavison · 2024-04-11T17:45:17Z

internal/service/redshift/logging_test.go

+					testAccCheckLoggingExists(ctx, resourceName, &log),
+					resource.TestCheckResourceAttrPair(resourceName, "cluster_identifier", clusterResourceName, "id"),
+					resource.TestCheckResourceAttr(resourceName, "log_destination_type", string(types.LogDestinationTypeCloudwatch)),
+				),


The basic test should check the values of all parameters

Addressed with 02d60ee

gdavison · 2024-04-11T17:46:38Z

internal/service/redshift/logging_test.go

+  log_destination_type = "cloudwatch"
+  log_exports          = ["connectionlog", "useractivitylog", "userlog"]


A basic test shouldn't set Optional parameters, so that it tests defaults

While technically optional, this argument is required when the log_destination_type is cloudwatch.

```console % make testacc PKG=redshift TESTS=TestAccRedshiftLogging_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftLogging_' -timeout 360m --- PASS: TestAccRedshiftLogging_disappears_Cluster (419.18s) --- PASS: TestAccRedshiftLogging_basic (427.15s) --- PASS: TestAccRedshiftLogging_s3 (437.89s) --- PASS: TestAccRedshiftLogging_disappears (472.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 478.531s ```

jar-b · 2024-04-11T19:15:54Z

Test results after adding missing checks:

% make testacc PKG=redshift TESTS=TestAccRedshiftLogging_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftLogging_'  -timeout 360m

--- PASS: TestAccRedshiftLogging_disappears_Cluster (419.18s)
--- PASS: TestAccRedshiftLogging_basic (427.15s)
--- PASS: TestAccRedshiftLogging_s3 (437.89s)
--- PASS: TestAccRedshiftLogging_disappears (472.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   478.531s

github-actions · 2024-04-11T23:01:29Z

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-05-12T02:08:45Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jar-b added the new-resource Introduces a new resource. label Apr 11, 2024

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024

r/aws_redshift_cluster: deprecate logging

844693a

This argument is deprecated in favor of the new, standalone `aws_redshift_logging` resource.

jar-b force-pushed the f-redshift_logging branch from e715201 to 844693a Compare April 11, 2024 16:13

gdavison self-assigned this Apr 11, 2024

gdavison requested changes Apr 11, 2024

View reviewed changes

jar-b mentioned this pull request Apr 11, 2024

r/aws_redshift_cluster: Remove logging argument #36870

Open

jar-b merged commit 6d4505f into main Apr 11, 2024
44 checks passed

jar-b deleted the f-redshift_logging branch April 11, 2024 20:21

github-actions bot added this to the v5.45.0 milestone Apr 11, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024

magreenbaum mentioned this pull request Apr 21, 2024

feat: Logging and Snapshot copy resources converted to standalone resource equivalents, MSV of Terraform raised to v1.3 terraform-aws-modules/terraform-aws-redshift#99

Merged

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_redshift_logging: new resource #36862

r/aws_redshift_logging: new resource #36862

jar-b commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

gdavison left a comment •

edited

Loading

gdavison Apr 11, 2024

jar-b Apr 11, 2024

gdavison Apr 11, 2024

jar-b Apr 11, 2024 •

edited

Loading

gdavison Apr 11, 2024

jar-b Apr 11, 2024

jar-b commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented May 12, 2024

		log_destination_type = "cloudwatch"
		log_exports = ["connectionlog", "useractivitylog", "userlog"]

r/aws_redshift_logging: new resource #36862

r/aws_redshift_logging: new resource #36862

Conversation

jar-b commented Apr 11, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Apr 11, 2024

Community Note

gdavison left a comment • edited Loading

Choose a reason for hiding this comment

gdavison Apr 11, 2024

Choose a reason for hiding this comment

jar-b Apr 11, 2024

Choose a reason for hiding this comment

gdavison Apr 11, 2024

Choose a reason for hiding this comment

jar-b Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

gdavison Apr 11, 2024

Choose a reason for hiding this comment

jar-b Apr 11, 2024

Choose a reason for hiding this comment

jar-b commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented May 12, 2024

gdavison left a comment •

edited

Loading

jar-b Apr 11, 2024 •

edited

Loading