Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't add tags on network interfaces because it's not supported yet in terraform-provider-aws #1407

Merged
merged 1 commit into from
May 28, 2021

Conversation

barryib
Copy link
Member

@barryib barryib commented May 28, 2021

PR o'clock

Description

Revert #1362

This is a ongoing feature in the terraform-provider-aws. Here the related PR hashicorp/terraform-provider-aws#18033.

Until that PR get merged, I'm reverting this.

Resolves #1406

Checklist

@barryib barryib changed the title fix: RDon't add tags on network interfaces fix: Don't add tags on network interfaces May 28, 2021
@barryib barryib changed the title fix: Don't add tags on network interfaces fix: Don't add tags on network interfaces because it's not supported yet in terraform-provider-aws May 28, 2021
@barryib barryib merged commit 65f5e2e into terraform-aws-modules:master May 28, 2021
@barryib barryib deleted the revert-1362 branch May 28, 2021 14:49
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Jun 1, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker Launch Template Invalid Resource Type
1 participant