Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network interfaces are missing tags #1361

Closed
alexmnyc opened this issue May 17, 2021 · 11 comments · Fixed by #1362 or #1563
Closed

Network interfaces are missing tags #1361

alexmnyc opened this issue May 17, 2021 · 11 comments · Fixed by #1362 or #1563

Comments

@alexmnyc
Copy link
Contributor

alexmnyc commented May 17, 2021

Please add a network interface tag specificiton to inherit parent tags here

tag_specifications {
         resource_type = "network-interface"
         tags =  var.tags merge with defaults
        }

network_interfaces {

@alexmnyc alexmnyc reopened this May 17, 2021
@alexmnyc alexmnyc changed the title tag_specifications is missing tags for default ENI that gets created. We need ability to add tags to the ENI's launched with launch templates Network interfaces are missing tags May 17, 2021
@barryib
Copy link
Member

barryib commented May 17, 2021

@alexmnyc Thanks for opening this issue. Can you please open a PR to address this ?

@alexmnyc
Copy link
Contributor Author

Sure thing

@alexmnyc
Copy link
Contributor Author

alexmnyc commented May 17, 2021

@barryib Done #1362

@alexmnyc
Copy link
Contributor Author

bump

@alexmnyc
Copy link
Contributor Author

alexmnyc commented May 25, 2021

@barryib PR is here #1362

@barryib barryib reopened this May 28, 2021
@barryib
Copy link
Member

barryib commented May 28, 2021

Reopening because it's reverted in #1407

@stale
Copy link

stale bot commented Aug 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 26, 2021
@nikitacr7
Copy link
Contributor

Hello @barryib , @antonbabenko
Do you have any plans to implement it? It looks like it's already implemented in hashicorp/terraform-provider-aws#20409

@stale stale bot removed the stale label Sep 1, 2021
@antonbabenko
Copy link
Member

Yes, it is now possible to add, please make a pull request for this feature. See similar PR #1397.

@nikitacr7
Copy link
Contributor

Hello @antonbabenko

Please review the PR: #1563

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants