r/launch_template: add support for network-interface tag specification

[xabinapal]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18029

Add support for network-interface resource types in launch_template tag specification blocks, as AWS now supports it during creation; even though documentation seems to be outdated both in AWS User Guide and in AWS API Reference.

Previously:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_data'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_data -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== CONT  TestAccAWSLaunchTemplate_data
    resource_aws_launch_template_test.go:381: Step 1/2 error: Error running pre-apply refresh: exit status 1

        Error: expected tag_specifications.0.resource_type to be one of [instance volume spot-instances-request elastic-gpu], got network-interface

          on terraform_plugin_test.tf line 89, in resource "aws_launch_template" "test":
          57:     resource_type = "network-interface"


--- FAIL: TestAccAWSLaunchTemplate_data (7.50s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	9.279s
FAIL
make: *** [testacc] Error 1

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_data'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_data -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== CONT  TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_data (51.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.701s
...

[github-actions]

Welcome @xabinapal 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[Aym3nTN]

Any updates on this PR?

[xabinapal]

I haven't received any feedback from the maintainers to know if something is required to merge this...

[Aym3nTN]

@hashicorp-cloud could someone look this PR please?

[alexmnyc]

bump. can we get this merged plz?

[gordonbondon]

Ooops, sorry, I did not see your PR before submitting my fix #20409 , but it's already merged and released.

[DrFaust92]

Closed via #20409

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.