Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an instrument documentation provider #19

Merged
merged 65 commits into from
Sep 15, 2018
Merged

Conversation

ethall
Copy link
Collaborator

@ethall ethall commented Sep 11, 2018

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • Pulling from a topic/feature/bugfix branch (right side).
  • Pulling against the dev branch (left side).
  • Code passes linting.
  • Code passes unit tests.
  • Code coverage is the same or better.
  • You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one.

Description

  • Added utility files to diff instrument command sets and documentation content.
  • Moved all instrument/2450 documentation to instrument/provider.
  • Instrument completions and signatures are now created dynamically at runtime.
  • 2450 provides an InstrumentSpec which is used to format instrument-specific documentation.
  • Command files are imported dynamically.

ethall and others added 30 commits September 4, 2018 23:04
Still need to add the get___CommandSet to all files listed after index.ts
@ethall ethall added the enhancement New feature or request label Sep 11, 2018
@ethall ethall self-assigned this Sep 11, 2018
@ethall ethall merged commit 42aca72 into dev Sep 15, 2018
@ethall ethall deleted the topic/doc-provider branch September 15, 2018 18:37
@ethall ethall mentioned this pull request Sep 16, 2018
ethall added a commit that referenced this pull request Sep 20, 2018
* Escaped asterisk in 2450 display.settext (#2)

* Updated documentation for all items in 2450 trigger.* (#4)

* Standardized wording of trigger line reset() functions (#6)

* Inclusion of Lua 5.0.3 keywords, standard library, and select sub-libraries (#12)

* Updated 2450 smu-source and smu-enums (#15)

* Corrected README anchor link for supported instruments (#16)

* Changed how signatures are matched (#17)

* Created an instrument documentation provider (#19)

* Added two missing 2450 namespaces (#20)

* Removed unnecessary asterisk escapes (#21)

* Extracted server handlers into a ContentParser class (#22)

* Updated CHANGELOG for PRs #20 & #21

* Travis CI support (#23)

* Added Codecov support (#24)

* Updated package files to v0.4.1
ethall added a commit that referenced this pull request Sep 21, 2018
* Added TSB file diff-er

* Added Instrument command set diff-er

* Moved native Lua items into Provider

* Added native Lua spec

* Fixed tspManager unregister bug

* Dynamic provider loading

* Removed useless CompletionItem sorting

* Fixed label typo for status.condition

* Added 2450 specification

* Removed developer build models from README

* Updated CHANGELOG

* Added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant