Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct anchor link for supported instruments #16

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Sep 5, 2018

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • [ X] Pulling from a topic/feature/bugfix branch (right side).
  • [ X] Pulling against the dev branch (left side).
  • [X ] Code passes linting.
  • [ X] Code passes unit tests.
  • [ X] Code coverage is the same or better.
  • [ X] You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one.

Description

Anchor link to "Supporting Instruments" in the README.md file was missing a dash.

@zkoppert zkoppert requested a review from ethall September 5, 2018 21:45
@ethall ethall merged commit 72e6760 into dev Sep 5, 2018
@ethall
Copy link
Collaborator

ethall commented Sep 5, 2018

Everything checks out!
I'll cherry-pick this commit into master shortly.

@ethall ethall deleted the bugfix/broken-supported-link branch September 5, 2018 21:59
@ethall ethall self-assigned this Sep 5, 2018
@ethall ethall added the bug Something isn't working label Sep 5, 2018
ethall added a commit that referenced this pull request Sep 7, 2018
* Escaped asterisk in 2450 display.settext (#2)

* Updated documentation for all items in 2450 trigger.* (#4)

* Standardized wording of trigger line reset() functions (#6)

* Moved the lua syntax to the third_party directory

* Added 2460 tsplink.reset

* Added 2461 tsplink.reset

* Inclusion of Lua 5.0.3 keywords, standard library, and select sub-libraries (#12)

Modified Lua.plist to more accurately reflect the on-instrument vanilla Lua features.

* Updated CHANGELOG header

* Updated 2450 smu-source and smu-enums (#15)

* Corrected README anchor link for supported instruments (#16)

* Changed how signatures are matched (#17)

* Added comments to signature provider

* Signatures must now be an exact match

Perform a 1:1 match against the SignatureInformation label before the first open paren instead of performing a partial match against the whole label

* Updated package-lock files

* Updated to version 0.4.0

* Updated CHANGELOG for Master merge
ethall added a commit that referenced this pull request Sep 20, 2018
* Escaped asterisk in 2450 display.settext (#2)

* Updated documentation for all items in 2450 trigger.* (#4)

* Standardized wording of trigger line reset() functions (#6)

* Inclusion of Lua 5.0.3 keywords, standard library, and select sub-libraries (#12)

* Updated 2450 smu-source and smu-enums (#15)

* Corrected README anchor link for supported instruments (#16)

* Changed how signatures are matched (#17)

* Created an instrument documentation provider (#19)

* Added two missing 2450 namespaces (#20)

* Removed unnecessary asterisk escapes (#21)

* Extracted server handlers into a ContentParser class (#22)

* Updated CHANGELOG for PRs #20 & #21

* Travis CI support (#23)

* Added Codecov support (#24)

* Updated package files to v0.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants