Bugfix/partial signature matching #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform a 1:1 match against the SignatureInformation label before the first open parenInstead of performing a partial match against the whole label
|
Fixes Issue #14 |
ethall
added a commit
that referenced
this pull request
Sep 5, 2018
* Added comments to signature provider * Signatures must now be an exact match Perform a 1:1 match against the SignatureInformation label before the first open paren instead of performing a partial match against the whole label
ethall
added a commit
that referenced
this pull request
Sep 7, 2018
* Escaped asterisk in 2450 display.settext (#2) * Updated documentation for all items in 2450 trigger.* (#4) * Standardized wording of trigger line reset() functions (#6) * Moved the lua syntax to the third_party directory * Added 2460 tsplink.reset * Added 2461 tsplink.reset * Inclusion of Lua 5.0.3 keywords, standard library, and select sub-libraries (#12) Modified Lua.plist to more accurately reflect the on-instrument vanilla Lua features. * Updated CHANGELOG header * Updated 2450 smu-source and smu-enums (#15) * Corrected README anchor link for supported instruments (#16) * Changed how signatures are matched (#17) * Added comments to signature provider * Signatures must now be an exact match Perform a 1:1 match against the SignatureInformation label before the first open paren instead of performing a partial match against the whole label * Updated package-lock files * Updated to version 0.4.0 * Updated CHANGELOG for Master merge
ethall
added a commit
that referenced
this pull request
Sep 20, 2018
* Escaped asterisk in 2450 display.settext (#2) * Updated documentation for all items in 2450 trigger.* (#4) * Standardized wording of trigger line reset() functions (#6) * Inclusion of Lua 5.0.3 keywords, standard library, and select sub-libraries (#12) * Updated 2450 smu-source and smu-enums (#15) * Corrected README anchor link for supported instruments (#16) * Changed how signatures are matched (#17) * Created an instrument documentation provider (#19) * Added two missing 2450 namespaces (#20) * Removed unnecessary asterisk escapes (#21) * Extracted server handlers into a ContentParser class (#22) * Updated CHANGELOG for PRs #20 & #21 * Travis CI support (#23) * Added Codecov support (#24) * Updated package files to v0.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please review the Contribution Guidelines before submitting.
devbranch (left side).Description
SignatureInformationlabel (minus the parenthesis and everything within it) to be included in the possible signature results