Fix for #2362, adding support per TaskRun runtime settings.

[NikeNano]

Changes

This PR updates the Pipelinerun object to allow for setting task specific podTemplates to handle variations on different task. This will allow users to not only relay on a podTemplate for all task but instead it can be set on task level giving it a higher degree of freedom. More information can be found here:

• PipelineRun should directly support per TaskRun runtime settings #2362
• Updated taskspec with nodeselector to allow for different nodeselector for each task.  #2297

• Updated the PipelineRunSpec to have a slice of PipelineRunTaskSpec which allows task specific settings.
• Set the TaskRun values based upon the PipelineRunTaskSpec if available.
• Added tests

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Allow PodTemplate to be set on task level at run time. 

[tekton-robot]

Hi @NikeNano. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[NikeNano]

Should I squash my commits? I see that I don't follow the expected standards.

[NikeNano]

/assign @dibyom

[dibyom]

/ok-to-test

[dibyom]

Thanks @NikeNano....I added a few comments. A couple of things to add would be 1. some docs 2. a YAML example (in the examples folder) that utilizes this feature!
(Also, yes, before we merge we'd like to rebase the commits 👼 )

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	88.5%	90.9%	2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.1%	2.4

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	88.5%	90.9%	2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.1%	2.4

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	88.5%	90.9%	2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.1%	2.4

[NikeNano]

Could some one help me out with interpreting the errors from the tests? I don't get the error messages.

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	88.5%	90.9%	2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.1%	2.4

[NikeNano]

Hi @dibyom could you take a look again :) Thanks!

[dibyom]

Build tests are failing due to:

I0418 15:07:36.162] =============================
I0418 15:07:36.163] ==== RUNNING BUILD TESTS ====
I0418 15:07:36.163] =============================
I0418 15:07:36.166] -------------------------------------------
I0418 15:07:36.167] ---- Checking go code style with gofmt ----
I0418 15:07:36.167] -------------------------------------------
I0418 15:07:38.692] diff -u pkg/apis/pipeline/v1alpha1/pipelinerun_types.go.orig pkg/apis/pipeline/v1alpha1/pipelinerun_types.go
I0418 15:07:38.692] --- pkg/apis/pipeline/v1alpha1/pipelinerun_types.go.orig	2020-04-18 15:07:37.883833184 +0000
I0418 15:07:38.693] +++ pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	2020-04-18 15:07:37.883833184 +0000
I0418 15:07:38.693] @@ -220,6 +220,7 @@
I0418 15:07:38.693]  	}
I0418 15:07:38.694]  	return false
I0418 15:07:38.694]  }
I0418 15:07:38.694] +
I0418 15:07:38.695]  // PipelineTaskRunSpec  can be used to configure specific
I0418 15:07:38.695]  // specs for a concrete Task
I0418 15:07:38.695]  type PipelineTaskRunSpec struct {

[NikeNano]

@dibyom is there anything more that I can improve?

[dibyom]

Couple of minor comments...mostly around tests. And would you mind filling out the Release notes section of the PR description? Otherwise, LGTM!

[NikeNano]

Couple of minor comments...mostly around tests. And would you mind filling out the Release notes section of the PR description? Otherwise, LGTM!

I will fix it :)

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	88.5%	90.9%	2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.1%	2.4
pkg/reconciler/pipelinerun/pipelinerun.go	72.4%	72.4%	0.1

[NikeNano]

/test pull-tekton-pipeline-integration-tests

[dibyom]

Looks like one of the YAML tests timed out

/test pull-tekton-pipeline-integration-tests

[NikeNano]

@dibyom the issues seem to be solved, the test seem to be a bit flaky, often time out :(

[dibyom]

Indeed, that test seems to be flaky.
/approve

[NikeNano]

@dibyom is there something more to do in order for this to be merged?

[vdemeester]

/cc @imjasonh @bobcatfish @afrittoli

[bobcatfish]

Let's do it! Haven't looked in much detail but from me re the API change at least:

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bobcatfish,dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/lgtm