Duplicate ways to specify ServiceAccountName for tasks in a PipelineRun

[jlpettersson]

Expected Behavior

A consistent way to declare ServiceAccountNames for tasks in a PipelineRun

Actual Behavior

There is now two ways, almost identical to specify ServiceAccountName for tasks in a PipelineRun. It is a bit confusing. What happens if I specify both fields but with different values?

spec:

  # existing way
  serviceAccountNames:
    - taskName: build-task
      serviceAccountName: sa-for-build
   
  # newly introduced
  taskRunSpecs:
    - taskName: build-task
      taskServiceAccountName: sa-for-build

The latter alternative seem to have been merged yesterday with #2389
/kind bug

[jlpettersson]

That syntax was actually requested: #2362

but then I think one of the fields should be deprecated and documentation updated. It is a bit confusing to have both in the documentation right now.

[vdemeester]

Yes serviceAccoutNames need to be marked as deprecated indeed 😇

[vdemeester]

/kind cleanup

[bobcatfish]

Thanks for catching this @jlpettersson !