Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler to use taskRun podTemplate spec #146

Closed
Tomcli opened this issue May 12, 2020 · 5 comments · Fixed by #153
Closed

Update compiler to use taskRun podTemplate spec #146

Tomcli opened this issue May 12, 2020 · 5 comments · Fixed by #153
Assignees

Comments

@Tomcli
Copy link
Member

Tomcli commented May 12, 2020

/kind feature
/help-wanted

Description:

Thanks to @NikeNano's PR tektoncd/pipeline#2389, taskRun podTemplate spec is now available in Tekton pipelineRun.

Current implementation: https://github.com/kubeflow/kfp-tekton/blob/master/sdk/FEATURES.md#affinity-node-selector-and-tolerations
Code: https://github.com/kubeflow/kfp-tekton/blob/master/sdk/python/kfp_tekton/compiler/compiler.py#L312-L319

Above is our current implementation to use pipelineRun podTemplate spec. Our goal is to migrate this to use taskRun podTemplate spec so it has the same behavior as Argo.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

1 similar comment
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@Tomcli Tomcli changed the title Update k8s spec to use taskRun podTemplate spec Update compiler to use taskRun podTemplate spec May 12, 2020
@k8s-ci-robot
Copy link

@Tomcli: The label(s) kind/help-wanted cannot be applied, because the repository doesn't have them

In response to this:

/kind help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NikeNano
Copy link
Member

@JohanWork maybe this would be something for you? I can help out.

@ckadner
Copy link
Member

ckadner commented May 19, 2020

/assign @NikeNano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants