Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to Task.BuildSep.Steps in all example… #209

Merged

Conversation

vdemeester
Copy link
Member

… also the guestbook integrationTestInDocker taskref name.

Fixes #202

Signed-off-by: Vincent Demeester [email protected]

… also the guestbook `integrationTestInDocker` taskref name.

Signed-off-by: Vincent Demeester <[email protected]>
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2018
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my LGTM
I am going to defer this to @bobcatfish.
I remember her saying this might not be required because we have some plan to extract the entry point for an image if command is not present.
In spite of that, this is good change which demonstrates good practice. (Users of task don't need to guess the command or look in to the image to figure out what the entry point is)

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tejal29, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@bobcatfish
Copy link
Collaborator

Thanks for doing this @vdemeester !

I remember her saying this might not be required because we have some plan to extract the entry point for an image if command is not present.
In spite of that, this is good change which demonstrates good practice. (Users of task don't need to guess the command or look in to the image to figure out what the entry point is)

In #183 @tanner-bruce is making it so that if there is no command, the controller will check the image to see if there is an entrypoint and use that.

That being said there are still caveats to that approach (e.g. if the image is in a private docker registry, or if the image changes b/w when the controller looks at it and the node pulls it) so i think we should strongly encourage explicitly providing command

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@@ -34,6 +35,7 @@ spec:
type: git
params:
- name: testImage
- name: testCommand
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :D

@knative-prow-robot knative-prow-robot merged commit c0a4731 into tektoncd:master Oct 31, 2018
@vdemeester vdemeester deleted the 202-example-with-command branch November 1, 2018 05:37
sthaha pushed a commit to sthaha/build-pipeline that referenced this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants