Skip to content

Commit

Permalink
Add command to Task.BuildSep.Steps in all example…
Browse files Browse the repository at this point in the history
… also the guestbook `integrationTestInDocker` taskref name.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Oct 31, 2018
1 parent fc53b3a commit c0a4731
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
2 changes: 2 additions & 0 deletions examples/build_task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ spec:
steps:
- name: build-and-push
image: gcr.io/kaniko-project/executor
command:
- /kaniko/executor
args:
- --dockerfile=${pathToDockerFile}
- --destination=$builtImage
2 changes: 2 additions & 0 deletions examples/deploy_tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
steps:
- name: deploy
image: kubernetes-helm
command: ['helm']
args: ['install', '--kube-context=${targetCluster}', '--set image=${image}', '${helmArgs}', '${pathToHelmChart}']

---
Expand All @@ -40,4 +41,5 @@ spec:
steps:
- name: runKubectl
image: k8s-kubectl
command: ['kubectl']
args: ['--use-context', '${targetCluster}', '--namespace', '${targetCluster.namespace}', 'apply', '-c', '${pathToFiles}', '${kubectlArgs}']
4 changes: 2 additions & 2 deletions examples/pipelines/guestbook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ spec:
key: testCluster
- name: int-test-osx # 3.a Run Integration tests for osx
taskRef:
name: integrationTestInDocker
name: integration-test-in-docker
inputSourceBindings:
- name: workspace
resourceRef:
Expand Down Expand Up @@ -93,4 +93,4 @@ spec:
value: guestbook/all-in-one/guestbook-all-in-one.yaml
clusterBindings:
- inputName: targetCluster
key: stagingCluster
key: stagingCluster
5 changes: 4 additions & 1 deletion examples/test_tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ spec:
steps:
- name: runMake
image: ubuntu
args: ['make', '${makeTarget}']
command: ['make']
args: ['${makeTarget}']

---
apiVersion: pipeline.knative.dev/v1alpha1
Expand All @@ -34,6 +35,7 @@ spec:
type: git
params:
- name: testImage
- name: testCommand
- name: testArgs
outputs:
results:
Expand All @@ -44,6 +46,7 @@ spec:
steps:
- name: runTests
image: '${testImage}'
command: ['${testCommand}']
args: ['${testArgs}']
volumeMounts:
- name: gac
Expand Down

0 comments on commit c0a4731

Please sign in to comment.