-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command
to Task.BuildSep.Steps
in all example…
#209
Add command
to Task.BuildSep.Steps
in all example…
#209
Conversation
… also the guestbook `integrationTestInDocker` taskref name. Signed-off-by: Vincent Demeester <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have my LGTM
I am going to defer this to @bobcatfish.
I remember her saying this might not be required because we have some plan to extract the entry point for an image if command is not present.
In spite of that, this is good change which demonstrates good practice. (Users of task don't need to guess the command or look in to the image to figure out what the entry point is)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tejal29, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for doing this @vdemeester !
In #183 @tanner-bruce is making it so that if there is no That being said there are still caveats to that approach (e.g. if the image is in a private docker registry, or if the image changes b/w when the controller looks at it and the node pulls it) so i think we should strongly encourage explicitly providing /lgtm |
@@ -34,6 +35,7 @@ spec: | |||
type: git | |||
params: | |||
- name: testImage | |||
- name: testCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :D
Remove gsutils
… also the guestbook
integrationTestInDocker
taskref name.Fixes #202
Signed-off-by: Vincent Demeester [email protected]