Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test commit #2

Closed
wants to merge 7 commits into from
Closed

test commit #2

wants to merge 7 commits into from

Conversation

tejal29
Copy link
Owner

@tejal29 tejal29 commented Sep 16, 2019

Relates to in case of new feature, this should point to issue/(s) which describes the feature

Fixes in case of a bug fix, this should point to a bug and any other related issue(s)

Should merge before : list any dependent PRs

Description

This is a test commit. Adds an empty space to Makefile.

Output Changes

Write n/a if not output or log lines added

Before

Paste skaffold output before your change

After

Paste skaffold output after your change

Next PRs.

In this section describe a list of follow up PRs if the current PR is a part of big feature change.

See example GoogleContainerTools#2811

Write n/a if not applicable.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing document changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes 
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

daddz and others added 7 commits September 16, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants