Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactors #2892

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Small refactors #2892

merged 1 commit into from
Sep 16, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 16, 2019

  1. Refactor signature for printStatusCheckSummary
  2. Move Deployment.WithStatus to withStatus since it was used for
    testing.

@tejal29 tejal29 force-pushed the refactor1 branch 2 times, most recently from 99948e4 to 10993d8 Compare September 16, 2019 20:51
@tejal29
Small refactors
d656933 
1. Refactor signature
2. Move `Deployment.WithStatus` to `withStatus` since it was used for
testing.
@codecov
Copy link

codecov bot commented Sep 16, 2019 •
edited
Loading

Codecov Report

Merging #2892 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/deployment.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/status_check.go 59.13% <50%> (ø) ⬆️

@tejal29 tejal29 merged commit 6ea013e into GoogleContainerTools:master Sep 16, 2019
@tejal29 tejal29 deleted the refactor1 branch September 18, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @priyawadhwa @googlebot