-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print status check summary when a status check is completed. #2811
Merged
tejal29
merged 15 commits into
GoogleContainerTools:master
from
tejal29:refactor-break-1
Sep 9, 2019
Merged
Print status check summary when a status check is completed. #2811
tejal29
merged 15 commits into
GoogleContainerTools:master
from
tejal29:refactor-break-1
Sep 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
September 4, 2019 22:05
Codecov Report
|
balopat
reviewed
Sep 5, 2019
balopat
reviewed
Sep 5, 2019
tejal29
force-pushed
the
refactor-break-1
branch
from
September 9, 2019 16:43
fbebaa2
to
9ac99c7
Compare
tejal29
force-pushed
the
refactor-break-1
branch
from
September 9, 2019 19:36
9ac99c7
to
242bafe
Compare
…into refactor-break-1
balopat
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - we implemented my comments via pairing
This was referenced Sep 16, 2019
Closed
This was referenced Sep 23, 2019
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #176
Should be merged after #2845, #2846
Description
In this change, we print a summary line after every deployment health check is complete.
Output Changes
Before
After
Next PRs
Resource
interface andDeployment
struct which implements theResource
interfacePod
struct which implements theResource
interface.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: