Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print status check summary when a status check is completed. #2811

Merged
merged 15 commits into from
Sep 9, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 4, 2019

Related to #176

Should be merged after #2845, #2846

Description

In this change, we print a summary line after every deployment health check is complete.

Output Changes

Before

tejaldesai@@microservices (add_deploy_stable_timer)$ skaffold run --default-repo=gcr.io/tejal-test --status-check
Generating tags...
...
Starting deploy...
kubectl client version: 1.11+
kubectl version 1.12.0 or greater is recommended for use with Skaffold
 - deployment.apps/leeroy-web configured
 - service/leeroy-app configured
 - deployment.apps/leeroy-app configured
Deploy complete in 3.791356548s
Waiting for deployments to stabilize
Deployments stabilized in 6.059712568s
You can also run [skaffold run --tail] to get the logs

After

tejaldesai@@microservices (refactor-break-1)$ skaffold run --default-repo gcr.io/tejal-test --status-check
Generating tags...
...
Starting deploy...
kubectl client version: 1.11+
kubectl version 1.12.0 or greater is recommended for use with Skaffold
 - deployment.apps/leeroy-web configured
 - service/leeroy-app configured
 - deployment.apps/leeroy-app configured
Deploy complete in 2.973935007s
Waiting for deployments to stabilize
 - deployment/leeroy-web is ready. [1/2 deployment(s) still pending]
 - deployment/leeroy-app is ready.
Deployments stabilized in 2.236126583s
You can also run [skaffold run --tail] to get the logs

tejaldesai@@microservices (refactor-break-1

Next PRs

  • show deployed resources intermediate states to provide users with some actionable feedback.
  • Add pods health check.
    • Refactor current health check code to add Resource interface and Deployment struct which implements the Resource interface
    • Add Pod struct which implements the Resource interface.
  • Event API integration for IDEs

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #2811 into master will decrease coverage by <.01%.
The diff coverage is 63.33%.

Impacted Files Coverage Δ
pkg/skaffold/runner/deploy.go 73.68% <100%> (ø) ⬆️
pkg/skaffold/deploy/status_check.go 61.79% <62.06%> (+2.42%) ⬆️

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - we implemented my comments via pairing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants