-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_TAXON_UNAMBIGUOUS #70
Comments
Comment by Paul Morris (@chicoreus) migrated from spreadsheet: |
Related to #57 |
Regarding "INTERNAL_PREREQUISITES_NOT_MET if all of the fields dwc:scientificName, dwc:subgenus, dwc:genus, dwc:family, dwc:order, dwc:class, dwc:phylum, dwc:kingdom are either not present or are EMPTY", would it make sense to say that only the ranks up to dwc:taxonRank are required? Also, would dwc:specificEpithet and dwc:infraspecificEpithet also be required where dwc:taxonRank is species or below? Also, can this be restricted to the primary taxon ranks, kingdom, phylum, class, order, family, genus, and have dwc:subgenus removed as an internal prerequisite. My apologies if these have already been discussed and resolved in the group. |
Thanks @ianengelbrecht. What we are saying if none of those are present, or all that are present are empty, then the test can't be run. If some are present (even dwc:subGenus), then the test can be run (it may fail and be Non-Compliant if it can't be resolved). It not saying that all have to be present, but saying that the INTERNAL_PREREQUISITES can't be satisfied if there are no relevant fields or all are empty (all ... are not present). Perhaps we could rewrite to make it clearer (i.e. none of these fields are present) but we have tried to be consistent in the way we have worded all these. I've got this correct haven't I @chicoreus |
Thanks @ArthurChapman, how bout "INTERNAL_PREREQUISITES_NOT_MET if none of the fields dwc:scientificName, dwc:subgenus, dwc:genus, dwc:family, dwc:order, dwc:class, dwc:phylum, dwc:kingdom are present, or all of those present are EMPTY;" |
Thanks @ianengelbrecht and @ArthurChapman. Unless I am mistaken (always possible), #105 covers that scenario. |
@Tasilee Yes, issue #105 (TG2_TAXON_VALIDATION_EMPTY ) is a test to cover that situation, but this test (TG2_VALIDATION_TAXON_AMBIGUOUS) still needs a response for cases where the response from TG2_TAXON_VALIDATION_EMPTY is NON_COMPLIANT. How about the following wording? INTERNAL_PREREQUISITES_NOT_MET if a) none of the fields dwc:scientificName, dwc:subgenus, dwc:genus, dwc:family, dwc:order, dwc:class, dwc:phylum, dwc:kingdom are present or b) all of those same fields that are present are EMPTY. |
Thanks @tucotuco - I can live with that :). @ArthurChapman? |
I think that is OK |
Thanks @ArthurChapman. Done |
…t continuing to run test if source authority is unknown.
…addressing a record with just a taxonID and no other terms with new SciNameUtils method validateTaxonID. Adding missing setValue(amendment) statements when proposing amendments.
Restructured Parameter(s) and Source authority |
Replaces "#46" in notes with "VALIDATION_SCIENTIFICNAME_FOUND (4c09f127-737b-4686-82a0-7c8e30841590)" |
One would hope that (all) the github issue references would be translated for the csv |
It won't automatically translate and we need to add the GUID |
A program like my Python code that I use for test spec dumps could easily do the translation (add Label and GUID) - and that creates a csv file. |
Well - wherever it occurs in the GitHub table - it will need to be translated. I have been working through them whenever I find them. |
Updated notes - changed "dwc:TaxonID" to "dwc:taxonID" |
Will need to include the new terms dwc:superfamily, dwc:tribe, dwc:subtribe tdwg/dwc#65 tdwg/dwc#45 tdwg/dwc#46 |
Added the terms dwc:superfamily, dwc:tribe, dwc:subtribe to the Information elements and Expected response, and updated Specification Last Updated. On this one, please check my Expected response. |
Amended Source Authority values to align with @chicoreus syntax From bdq:sourceAuthority default = "GBIF Backbone Taxonomy" [https://doi.org/10.15468/39omei] | to bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]} |
…pecifications. Addressed tdwg/bdq#70 VALIDATION_TAXON_UNAMBIGUOUS Updated metadata, ProvidesVersion and Specification annotations. Added support for gbif:{integer} pseudo-namespace. Improved support for specification, still needs work noted with TODO comments. Removed reviewed stub method. Added test cases. Added comparator to Taxon class to compare non-empty higher ranks between a Taxon and a NameMatch. Handling parsing of json with class or with clazz in GBIF api response, silent change from clazz?
…pecifications. Addressed tdwg/bdq#70 VALIDATION_TAXON_UNAMBIGUOUS improved support for plausible matching on scientific name authorship for variations in which terms contain the authorship. Clarified intent of ScientificNameComparator.compare(), adding to documentation and renaming as compareWithoutAuthor(). Added test cases to cover the multiple paths in the specification and more cases of ambiregnal homonyms. Unit tests and integration testas all passing.
Changed positive example (and test data that it was derived from) from dwc:scientificName="Triplex rosarium Perry, 1811 to dwc:scientificName="Triplex rosaria Perry, 1811 |
…aining tests tdwg/bdq#70 VALIDATION_TAXON_UNAMBIGUOUS and tdwg/bdq#123 VALIDATION_CLASSIFICATION_CONSISTENT. Metadata, including source authority values, updated. Some cleanup of other comments, and consistency of comments in defaults class.
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted": This one needs checking. My logic was from the Expected Response. Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
Changed all Information Elements to "ActedUpon" as per Paul's Java Code |
…through change to scientificNameID, at point where unit tests are passing, though unit tests may not all be up to date with specification. Added block of code to handle COMPLIANT case 1, adding comments on checked portions of specification.
… up code to reflect primacy of presence of scientificNameID and use of other terms to disambguate instead of checking consistency, improving comments, adding some test cases, still needs work on clause (4) disambiguation.
…tdwg/bdq#70 VALIDATION_TAXON_UNAMBIGUOUS
…aID 523 lookup including cultivar name from APNI for tdwg/bdq#70.
The text was updated successfully, but these errors were encountered: