Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_KINGDOM_STANDARDIZED #90

Closed
iDigBioBot opened this issue Jan 5, 2018 · 7 comments
Closed

TG2-AMENDMENT_KINGDOM_STANDARDIZED #90

iDigBioBot opened this issue Jan 5, 2018 · 7 comments
Labels
Amendment Conformance DO NOT IMPLEMENT A potential test that it is not recommended be implemented NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID bd96600d-570f-44c9-a117-82e7f34e95c7
Label AMENDMENT_KINGDOM_STANDARDIZED
Description Can the value for kingdom be standardized against the source authority?
TestType Amendment
Darwin Core Class Taxon
Information Elements ActedUpon dwc:kingdom
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:kingdom is bdq:Empty; AMENDED dwc:kingdom if it can be been unambiguously interpreted in the bdq:sourceAuthority; otherwise NOT_CHANGED.
Data Quality Dimension Conformance
Term-Actions KINGDOM_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}
Specification Last Updated 2024-09-18
Examples [dwc:family="Animals": Response.status=AMENDED, Response.result=dwc:order="Animalia", Response.comment="Input field contains interpretable value for kingdom"]
[dwc:kingdom="X": Response.status=NOT_AMENDED, Response.result="", Response.comment="Value for kingdom not found in source authority"]
Source iDigBio
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes For reference, possible values of dwc:kingdom can be found at https://registry.gbif.org/vocabulary/Kingdom/concepts.
@iDigBioBot
Copy link
Collaborator Author

Comment by Paul Morris (@chicoreus) migrated from spreadsheet:
Specification unclear. Is this conforming the higher classification to an aggregator's preferred classification. Replace the {higher taxon}_REPLACED tests with a pair HIGHER_CLASSIFICATION_IN_VOCABULARY, HIGHER_CLASSIFICATION_CONFORMED_TO_VOCABULARY.

@godfoder godfoder added the DO NOT IMPLEMENT A potential test that it is not recommended be implemented label Jan 18, 2018
@godfoder
Copy link
Contributor

We are recommending that implementers do not implement individual amendments for each rank, preferring instead that amendments to taxonomic terms be made for the entire higher taxonomy at once, as in #57 and #70 .

@Tasilee Tasilee added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 15, 2024
@Tasilee
Copy link
Collaborator

Tasilee commented Feb 22, 2024

Updated parameters to align with current template

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Standardized reference to "EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available" in Expected Response.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

to

bdq:sourceAuthority default = "GBIF Kingdom Vocabulary" [https://api.gbif.org/v1/vocabularies/Kingdom]} {"dwc:kingdom vocabulary API" [https://api.gbif.org/v1/vocabularies/Kingdom/concepts]}

@chicoreus
Copy link
Collaborator

I disagree. Like #81 this needs to be reverted to the default sourceAuthority consistent with the rest of the higher taxonomy terms. Doing otherwise adds substantial complexity and potential problems for alignment between two different controlled vocabularies, as well as increased complexity for implementation.

The source authority should be:

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

@Tasilee
Copy link
Collaborator

Tasilee commented May 13, 2024

Changed Source Authority from

bdq:sourceAuthority default = "GBIF Kingdom Vocabulary" [https://api.gbif.org/v1/vocabularies/Kingdom]} {"dwc:kingdom vocabulary API" [https://api.gbif.org/v1/vocabularies/Kingdom/concepts]}

to

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment Conformance DO NOT IMPLEMENT A potential test that it is not recommended be implemented NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 VOCABULARY
Projects
None yet
Development

No branches or pull requests

5 participants