Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate review: Specify in which order properties are accessed when passing object to implementation-defined operation #1388

Closed
ptomato opened this issue Feb 25, 2021 · 0 comments · Fixed by #1430
Closed

Delegate review: Specify in which order properties are accessed when passing object to implementation-defined operation #1388

ptomato opened this issue Feb 25, 2021 · 0 comments · Fixed by #1430
Assignees
@cjtenny
Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! spec-text Specification text involved tc39-review
Milestone
Stage 3

Comments

@ptomato
Copy link
Collaborator

ptomato commented Feb 25, 2021

From #1383. In implementation-defined operations such as non-ISO calendars (e.g. https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.datefromfields) it must be specified in which order properties from these objects are accessed. The objects should be copied and objects containing data properties should be passed to the operations, so that getters are not called more than once.

cc @bmeck
@ptomato ptomato added spec-text Specification text involved non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! labels Feb 25, 2021
@ptomato ptomato added this to the Stage 3 milestone Feb 25, 2021
@ptomato ptomato mentioned this issue Feb 25, 2021
Closed
@cjtenny cjtenny self-assigned this Mar 4, 2021
cjtenny added a commit that referenced this issue Mar 8, 2021
@cjtenny
Ensure that implementation-defined Intl operations access properties …
e9377db 
…in consistent order and only call getters once.

Fixes #1388.
This was referenced Mar 8, 2021
Merged
Closed
cjtenny added a commit that referenced this issue Mar 8, 2021
@cjtenny
Ensure that implementation-defined Intl operations access properties …
50ba182 
…in consistent order and only call getters once.

Fixes #1388.
cjtenny added a commit that referenced this issue Mar 9, 2021
@cjtenny
Ensure that implementation-defined Intl operations access properties …
1ce0365 
…in consistent order and only call getters once.

Fixes #1388.
cjtenny added a commit that referenced this issue Mar 9, 2021
@cjtenny
Ensure that implementation-defined Intl operations access properties …
b38fe9b 
…in consistent order and only call getters once.

Fixes #1388.
ptomato pushed a commit that referenced this issue Mar 9, 2021
@cjtenny @ptomato
Ensure that implementation-defined Intl operations access properties …
3047637 
…in consistent order and only call getters once.

Fixes #1388.
cjtenny added a commit that referenced this issue Mar 9, 2021
@cjtenny
Ensure that implementation-defined Intl operations access properties …
85a828b 
…in consistent order and only call getters once. (#1430)

Fixes #1388.
@ptomato ptomato mentioned this issue Apr 1, 2021
Closed
@ptomato ptomato mentioned this issue Jul 9, 2021
Closed
@ptomato ptomato mentioned this issue Oct 6, 2021
Closed
@ptomato ptomato mentioned this issue Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjtenny cjtenny

Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! spec-text Specification text involved tc39-review
Projects
None yet
Milestone
Stage 3
Development

Successfully merging a pull request may close this issue.

Ensure that implementation-defined Intl operations access properties … tc39/proposal-temporal
2 participants
@ptomato @cjtenny