Delegate review: Bradley Farias

[ptomato]

Thread for discussions / signing off from designated reviewer @bmeck, in preparation for Stage 3

[ptomato]

@bmeck thanks for joining the Temporal meeting today!

Here are the actionable items that I distilled from your comments during the meeting:

• In the parts that mention the "time zone information" being updated, it's ambiguous whether this means the information about which time zone the system is in, or the information in the time zone database. It's the latter and should be changed accordingly.
• Remove references to "immutable Object" from the text as it doesn't have a definition within the specification, Temporal objects are only "immutable" from the user's perspective.
• In cases where an options object (from NormalizeOptionsObject) is passed to a non-ISO-calendar operation (which is implementation-defined and not part of the specification) then it still needs to be specified in which order the properties of the options object are accessed.
• Possible name change for abstract operations to make clear that they concern only the ISO calendar (e.g., RejectDate(year, month, day) → RejectISODate(year, month, day) or RejectDate(isoYear, isoMonth, isoDay))
• I'll notify you on the upcoming change from delegate review: Calendar and TimeZone should be brand-checked, not normal, objects #1294 about how calendar objects are stored in internal slots.
• Examine operations where property reads are interspersed with operations that may throw.
• Ensure Get vs GetOwnProperty are used with the corresponding enumeration, and don't use own keys.

If you don't mind, I'll go ahead and open issues for the first four. The last two, are they things that you intend to look out for while completing your review or are there things that you already feel should be changed?

[ptomato]

• "time zone information" → Delegate review: Clarify "updating the time zone information" #1386
• "immutable Object" → Delegate review: remove references to "immutable Object" #1387
• order of getters → Delegate review: Specify in which order properties are accessed when passing object to implementation-defined operation #1388
• names of abstract operations → Delegate review: Clarify names of abstract operations applying to internal ISO data model #1389

[ptomato]

Nothing left to do here.