Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that implementation-defined Intl operations access properties … #1430

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

cjtenny
Copy link
Collaborator

@cjtenny cjtenny commented Mar 8, 2021

…in consistent order and only call getters once.

Fixes #1388.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1430 (c584506) into main (97b882c) will decrease coverage by 46.69%.
The diff coverage is 32.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1430       +/-   ##
===========================================
- Coverage   95.73%   49.04%   -46.70%     
===========================================
  Files          19       18        -1     
  Lines       11143     4961     -6182     
  Branches     1804     1082      -722     
===========================================
- Hits        10668     2433     -8235     
- Misses        472     2118     +1646     
- Partials        3      410      +407     
Flag Coverage Δ
test262 49.04% <32.60%> (+0.02%) ⬆️
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/calendar.mjs 17.11% <30.43%> (-77.06%) ⬇️
polyfill/lib/ecmascript.mjs 54.64% <31.81%> (-41.50%) ⬇️
polyfill/lib/timezone.mjs 65.51% <100.00%> (-28.24%) ⬇️
polyfill/lib/zoneddatetime.mjs 42.56% <0.00%> (-55.37%) ⬇️
polyfill/lib/plaindate.mjs 49.38% <0.00%> (-46.66%) ⬇️
polyfill/lib/duration.mjs 53.36% <0.00%> (-44.94%) ⬇️
polyfill/lib/plaintime.mjs 55.12% <0.00%> (-41.50%) ⬇️
polyfill/lib/plaindatetime.mjs 54.31% <0.00%> (-41.20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b882c...3047637. Read the comment docs.

spec/intl.html Outdated Show resolved Hide resolved
@cjtenny cjtenny force-pushed the cjtenny/1388 branch 2 times, most recently from 50ba182 to 1ce0365 Compare March 9, 2021 01:36
Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all looks correct.

polyfill/lib/ecmascript.mjs Outdated Show resolved Hide resolved
polyfill/lib/ecmascript.mjs Outdated Show resolved Hide resolved
…in consistent order and only call getters once.

Fixes #1388.
@cjtenny cjtenny merged commit 85a828b into main Mar 9, 2021
@cjtenny cjtenny deleted the cjtenny/1388 branch March 9, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants