Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some Web APIs on ShadowRealms #331

Closed
13 of 14 tasks
Ms2ger opened this issue Oct 12, 2021 · 17 comments
Closed
13 of 14 tasks

Expose some Web APIs on ShadowRealms #331

Ms2ger opened this issue Oct 12, 2021 · 17 comments

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 12, 2021

Meta issue - relevant changes will be made to the Web specs.

Ms2ger added a commit to Ms2ger/url that referenced this issue Oct 12, 2021
@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Oct 12, 2021

Depends on whatwg/webidl#526

Ms2ger added a commit to whatwg/dom that referenced this issue Oct 14, 2021
Ms2ger added a commit to WebAssembly/spec that referenced this issue Oct 14, 2021
annevk pushed a commit to whatwg/dom that referenced this issue Oct 14, 2021
@annevk
Copy link
Member

annevk commented Oct 14, 2021

This has implementer interest, so I'm thinking that once there are tests and there's bugs filed, we merge all the relevant WHATWG PRs together. Does that seem reasonable?

cc @domenic @padenot @codehag

@codehag
Copy link
Contributor

codehag commented Oct 14, 2021

That sounds reasonable to me.

Ms2ger added a commit to Igalia/streams that referenced this issue Oct 14, 2021
Ms2ger added a commit to Igalia/scheduling-apis that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/compression that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/hr-time that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/performance-timeline that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/user-timing that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/resource-timing that referenced this issue Oct 20, 2021
Ms2ger added a commit to Igalia/server-timing that referenced this issue Oct 20, 2021
Ms2ger added a commit to whatwg/html that referenced this issue Oct 20, 2021
@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Nov 3, 2021

I put a checklist in the issue summary

@smaug----
Copy link

smaug---- commented Feb 7, 2022

How did we get this list of things to expose everywhere? There are some very surprising APIs in the list.

@bakkot
Copy link

bakkot commented Feb 7, 2022

@smaug---- Anything in particular?

@smaug----
Copy link

Especially Scheduling API, but possibly also resource timing, if fetch isn't really exposed.
And PromiseRejectionEvent is odd if the global in ShadowRealm is just a normal JS object, not an EventTarget.

@leobalter
Copy link
Member

@smaug---- on the scheduling API we followed the advice we got there and decided to not add it (that issue is now closed and removed).

We had a sync with some implementers and other stakeholders that resolved into this list. I believe we can work this out.

Perhaps a similar flexibility can be observed to resource timing. @Ms2ger WDYT?

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Feb 8, 2022

Happy to reconsider, of course. I don't claim to fully understand resource timing, but perhaps it is useful for tracking module loading?

Ms2ger added a commit to web-platform-tests/wpt that referenced this issue Feb 10, 2022
caitp pushed a commit to web-platform-tests/wpt that referenced this issue Feb 10, 2022
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 26, 2022
… a=testonly

Automatic update from web-platform-tests
Add tests for Web APIs in ShadowRealms. (#32800)

Ref. tc39/proposal-shadowrealm#331.
--

wpt-commits: 0e5b126cd0a8da9186b738b8c9278d19b594c51f
wpt-pr: 32800
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Mar 1, 2022
… a=testonly

Automatic update from web-platform-tests
Add tests for Web APIs in ShadowRealms. (#32800)

Ref. tc39/proposal-shadowrealm#331.
--

wpt-commits: 0e5b126cd0a8da9186b738b8c9278d19b594c51f
wpt-pr: 32800
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 8, 2022
… a=testonly

Automatic update from web-platform-tests
Add tests for Web APIs in ShadowRealms. (#32800)

Ref. tc39/proposal-shadowrealm#331.
--

wpt-commits: 0e5b126cd0a8da9186b738b8c9278d19b594c51f
wpt-pr: 32800
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Mar 8, 2022
… a=testonly

Automatic update from web-platform-tests
Add tests for Web APIs in ShadowRealms. (#32800)

Ref. tc39/proposal-shadowrealm#331.
--

wpt-commits: 0e5b126cd0a8da9186b738b8c9278d19b594c51f
wpt-pr: 32800
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@littledan
Copy link
Member

It looks like all of the relevant PRs to various specs have landed, with the sole exception of console (just blocking on manual tests--maybe we should just push back on that request). The only thing I see missing is some machinery in WebIDL: I don't think these APIs are actually exposed to ShadowRealm at the moment, as ShadowRealm is not an interface. We should probably add some plumbing in WebIDL to handle it specially.

@annevk
Copy link
Member

annevk commented Jun 8, 2022

I think it would be better to make the relevant requirements in HTML, as that already deals with most of the globals of the web platform and integration with ShadowRealm.

Ms2ger added a commit to Igalia/console that referenced this issue Jun 10, 2022
@littledan
Copy link
Member

@annevk How would this be handled in HTML? I explained the concrete problem here; it's hard for me to imagine the fix coming in HTML without HTML reaching rather deep into WebIDL.

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Aug 8, 2022

Everything I wanted to do in this issue is done.

@BadassGhost

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants