Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose everywhere #209

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Expose everywhere #209

merged 1 commit into from
Jun 15, 2022

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Jan 18, 2022

Ref: tc39/proposal-shadowrealm#331

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@Ms2ger
Copy link
Member Author

Ms2ger commented Jan 18, 2022

r? @domfarolino

@terinjokes
Copy link
Collaborator

LGTM, though I'm wondering if we need to specify the side effects that happen in some of these other environments.

@Ms2ger
Copy link
Member Author

Ms2ger commented Jan 18, 2022

On a first glance, I'm not seeing anything that obviously needs adjusting, but let me know if you disagree.

@annevk
Copy link
Member

annevk commented Jan 24, 2022

@terinjokes @domfarolino can you sort out the CI failure? Seems like an image might need width/height attributes?

@domfarolino domfarolino reopened this May 19, 2022
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding tests, you have:

TBD but quite trivial

This PR LGTM, but do you plan on adding tests?

@Ms2ger
Copy link
Member Author

Ms2ger commented May 26, 2022

@domfarolino For tests, I'll make sure to add an idlharness test as soon as the IDL changes propagate into the wpt repo after this PR is merged. I don't think there's much else I can test - maybe a manual test that the messages show up?

@domfarolino
Copy link
Member

A manual test would be nice I think

@Ms2ger
Copy link
Member Author

Ms2ger commented Jun 9, 2022

Tests are up at web-platform-tests/wpt#34361

@domfarolino
Copy link
Member

This and the tests LGTM. GitHub is complaining about the branch not being up to date, so if you could fix that then I think we'd be good to go.

@Ms2ger Ms2ger force-pushed the expose-everywhere branch from 7bb6921 to 334b6f3 Compare June 10, 2022 07:44
@Ms2ger
Copy link
Member Author

Ms2ger commented Jun 10, 2022

Done!

@domfarolino
Copy link
Member

Great, feel free to merge the tests whenever and I'll go ahead and merge this.

@Ms2ger
Copy link
Member Author

Ms2ger commented Jun 14, 2022

Merged the wpt pr, thank you

@domfarolino domfarolino merged commit 812120b into whatwg:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants