Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Integration: Performance mixin? #387

Closed
mgaudet opened this issue Apr 14, 2023 · 9 comments
Closed

Web Integration: Performance mixin? #387

mgaudet opened this issue Apr 14, 2023 · 9 comments
Assignees
Labels

Comments

@mgaudet
Copy link

mgaudet commented Apr 14, 2023

In #331 a few performance related PRs were merged; but I don't think any of them merged an actual performance object. In the hr-time spec that's the

partial interface mixin WindowOrWorkerGlobalScope {
  [Replaceable] readonly attribute Performance performance;
};

If we want to expose the Performance interfaces, we need a Performance object to act as receiver for some of the methods of interest.

@caridy
Copy link
Collaborator

caridy commented Feb 5, 2024

cc @ptomato

@ptomato
Copy link
Collaborator

ptomato commented Feb 6, 2024

@caridy @leobalter Whoops, this looks like my mistake. Performance is still marked as Exposed=(Window,Worker) in WPT's IDL files, which is what I based my research on for the list of included APIs. But it looks like it should be Exposed=* as per w3c/hr-time#130 and w3c/performance-timeline#193. I'll go through the other PRs listed in #331 and see if there's any other discrepancies.

@mgaudet
Copy link
Author

mgaudet commented Feb 6, 2024

To be clear, based on the rationale in #393, performance shouldn't be included (and in general, I'd support its exclusion).

@caridy
Copy link
Collaborator

caridy commented Feb 6, 2024

I don't think performance violate the criteria that we are using for inclusion/exclusion. Does it break confidentiality? Is performance.memory.usedJSHeapSize and co. problematic from that perspective?

Update: after further review of the new API (https://developer.mozilla.org/en-US/docs/Web/API/Performance/measureUserAgentSpecificMemory), that seems a lot more problematic. Certainly leaking origin information.

@mgaudet
Copy link
Author

mgaudet commented Feb 6, 2024

Also just generally “host access”

@caridy
Copy link
Collaborator

caridy commented Feb 7, 2024

I have added my notes on performance here https://github.com/tc39/proposal-shadowrealm/blob/main/apis.md#performance-api

@caridy
Copy link
Collaborator

caridy commented Feb 8, 2024

@ptomato is there anything else pending to exclude performance from the initial list?

@ptomato
Copy link
Collaborator

ptomato commented Feb 8, 2024

Yes, we should remove the [Exposed=*] annotations from the W3C specs for performance and its properties.

@ptomato
Copy link
Collaborator

ptomato commented Feb 13, 2024

I found that these were already reverted.

(So that's why they didn't show up in WPT's IDL files! ref #387 (comment))

So I think we're good in terms of excluding performance from the initial list.

@ptomato ptomato closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants