Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new diagrams (#5640) #5651

Merged
merged 14 commits into from
Sep 7, 2023
Merged

docs: new diagrams (#5640) #5651

merged 14 commits into from
Sep 7, 2023

Conversation

stringhandler
Copy link
Collaborator

@stringhandler stringhandler commented Aug 22, 2023

Adds new documentation and diagrams

Adds new documentation and diagrams
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 22, 2023
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Test Results (CI)

1 199 tests   1 199 ✔️  10m 11s ⏱️
     38 suites         0 💤
       1 files           0

Results for commit fba435e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Test Results (Integration tests)

27 tests  +27   27 ✔️ +27   12m 37s ⏱️ + 12m 37s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ±  0 

Results for commit fba435e. ± Comparison against base commit a4b634a.

♻️ This comment has been updated with latest results.

stringhandler and others added 12 commits August 29, 2023 10:14
Description
---

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

---------

Co-authored-by: Brian Pearce <[email protected]>
Co-authored-by: Cayle Sharrock <[email protected]>
Description
---
Adds in a rough draft of the header sync diagram
Description
---
Adds new documentation and diagrams for comms inbound messaging stack
and inbound protocol negotiation.

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Description
---
Added block sync diagram

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Description
---
Add a diagram for block reconciliation.

Motivation and Context
---
So everyone can know more things.

How Has This Been Tested?
---
I looked at the diagram, and it looked back into my soul.

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify
Description
---

Update the state machine and listening state diagrams to correctly
display.
Description
---
New flow and sequence diagrams for horizon synchronisation

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Description
---
Updates to block_sync diagram

Motivation and Context
---

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Description
---
add decide_sync diagram
finish state machine diagram
Description
---
adds in a chain metadata service diagram
Description
---
update the diagram for listening state
Description
---
removes all code changes from diagram branch
@ghpbot-tari-project ghpbot-tari-project added CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-conflicts Process - The PR has merge conflicts that need to be resolved labels Sep 7, 2023
@stringhandler stringhandler marked this pull request as ready for review September 7, 2023 07:17
@ghpbot-tari-project ghpbot-tari-project removed the P-conflicts Process - The PR has merge conflicts that need to be resolved label Sep 7, 2023
@stringhandler stringhandler merged commit 3f82852 into development Sep 7, 2023
13 of 15 checks passed
@stringhandler stringhandler deleted the feature-diagrams branch September 8, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants