Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new diagrams (#5640) #5678

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 28, 2023

Description

Adds new documentation and diagrams for comms inbound messaging stack and inbound protocol negotiation.

Motivation and Context

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Test Results (CI)

1 191 tests  ±0   1 191 ✔️ ±0   8m 55s ⏱️ -12s
     37 suites ±0          0 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 28de445. ± Comparison against base commit 50bca9c.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Test Results (Integration tests)

  2 files  ±0  11 suites  ±0   15m 53s ⏱️ + 2m 7s
27 tests ±0  26 ✔️  - 1  0 💤 ±0  1 +1 
28 runs  +1  27 ✔️ ±0  0 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 28de445. ± Comparison against base commit 50bca9c.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 29, 2023
@stringhandler stringhandler merged commit 87170cd into tari-project:feature-diagrams Aug 29, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants