Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable profiling page build on pull requests #2048

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 7, 2022

📝 Description

Type: 📝 documentation | 🎢 infrastructure

  • Avoids running profiling notebooks under on pull_request_target events. Saves 3-4' on each run
  • push and workflow_dispatch remains unchanged

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Tested the pull_request_target on my fork: https://github.com/epassaro/tardis/actions/runs/2457627178

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2048 (90ce007) into master (b394f46) will not change coverage.
The diff coverage is n/a.

❗ Current head 90ce007 differs from pull request most recent head 4feaf93. Consider uploading reports for the commit 4feaf93 to get more accurate results

@@           Coverage Diff           @@
##           master    #2048   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          76       76           
  Lines        8599     8599           
=======================================
  Hits         5017     5017           
  Misses       3582     3582           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@epassaro epassaro marked this pull request as ready for review June 8, 2022 15:25
@epassaro epassaro marked this pull request as draft June 10, 2022 15:45
@epassaro epassaro marked this pull request as ready for review June 10, 2022 23:24
@epassaro epassaro marked this pull request as draft June 13, 2022 16:02
@epassaro epassaro marked this pull request as ready for review June 14, 2022 12:26
@epassaro epassaro merged commit 16f5963 into tardis-sn:master Jun 14, 2022
epassaro added a commit to epassaro/tardis that referenced this pull request Jun 14, 2022
* Polish up Quickstart guide (tardis-sn#2042)

* Polish up Quickstart guide

* Remove backticks

* Try to fix traitlets FutureWarning

* Change loglevel

* Minor changes

* Add plt.show()

* Hide duplicated stderr messages

* Add read more section

* Minor changes

* Final changes

* Print config file

* Use export_convergence_plot param

* Add quickstart line in installation section

* Minor changes

* Disable profiling page build on pull requests (tardis-sn#2048)

* Change developer installation command (tardis-sn#2053)

* Define inputs
This was referenced Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants