Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Docs Warnings #2093

Merged
merged 9 commits into from
Aug 2, 2022
Merged

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented Jul 15, 2022

📝 Description

Type: 📝 documentation

Fixes issues in the documentation to eliminate warnings and clean up the docs build:

  • Fixed headers on gamma ray deposition docs and included it within the documentation. Also ran first cell so it is not run in docs builds.
  • Fixed API documentation formatting issues in the formal integral and configuration validators.
  • Fixed links.
  • Fixed issues with .gitignore when building the arepo_to_tardis notebook.
  • Closes Profiling pages not built in docs #2100. I ran the first cell in one of the notebooks and ran the entire notebook in the second one (since it produced useful output) so that these notebooks do not run, though if a user wants them to run in their docs build, these notebooks can be restarted prior to the build.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

See docs build: https://github.com/tardis-sn/tardis/actions/runs/2691656319

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Docs built on GitHub with no warnings.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@isaacgsmith isaacgsmith marked this pull request as draft July 15, 2022 21:35
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #2093 (12f6599) into master (a2ed8b5) will increase coverage by 3.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   58.13%   61.46%   +3.32%     
==========================================
  Files          75       75              
  Lines        8602     8620      +18     
==========================================
+ Hits         5001     5298     +297     
+ Misses       3601     3322     -279     
Impacted Files Coverage Δ
tardis/io/config_validator.py 90.47% <ø> (ø)
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <ø> (ø)
tardis/simulation/base.py 83.85% <0.00%> (+0.22%) ⬆️
tardis/montecarlo/montecarlo_numba/base.py 31.35% <0.00%> (+0.84%) ⬆️
tardis/io/logger/logger.py 75.86% <0.00%> (+5.17%) ⬆️
tardis/montecarlo/montecarlo_numba/r_packet.py 61.53% <0.00%> (+11.53%) ⬆️
tardis/visualization/widgets/custom_abundance.py 59.53% <0.00%> (+42.96%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@isaacgsmith isaacgsmith marked this pull request as ready for review July 18, 2022 14:26
@isaacgsmith isaacgsmith requested review from AlexHls and removed request for jaladh-singhal July 18, 2022 15:33
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending @epassaro comments on the profiling page build.

@andrewfullard andrewfullard self-requested a review August 2, 2022 14:16
@andrewfullard andrewfullard merged commit b1a5fee into tardis-sn:master Aug 2, 2022
@isaacgsmith isaacgsmith deleted the warning_fix branch August 3, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiling pages not built in docs
3 participants