Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling pages not built in docs #2100

Closed
isaacgsmith opened this issue Jul 18, 2022 · 0 comments · Fixed by #2093
Closed

Profiling pages not built in docs #2100

isaacgsmith opened this issue Jul 18, 2022 · 0 comments · Fixed by #2093
Assignees

Comments

@isaacgsmith
Copy link
Member

The profiling notebooks are not built in the documentation -- see https://tardis-sn.github.io/tardis/contributing/development/profiling/index.html. This also creates warnings in the documentation build.

This is a result of PR #2048, which I believe is supposed to only exclude these pages for docs built off of pull requests, though this is not the case. Even then, though, this will create warnings in the documentation which would prevent the implementation of PR #2094. I have attempted an (imperfect) solution in PR #2093, though if there is a better way that will not result in warnings in the documentation that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants