Allow float values for dash parameter #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse float values - Scale dash values with a fixed scale factor "20" (In accordance with JS) before filling the dash texture - Make sure to adjust texture coordinate to account for the texture data - fixes #951
karimnaaji
approved these changes
Jan 27, 2017
matteblair
reviewed
Jan 27, 2017
| m_shaderProgram->addSourceBlock("defines", "#define TANGRAM_DASHLINE_TEX_SCALE " + | ||
| std::to_string(dash_scale) + "\n", false); | ||
| } else { | ||
| m_shaderProgram->addSourceBlock("defines", "#define TANGRAM_DASHLINE_TEX_SCALE 1", |
There was a problem hiding this comment.
Have you tested this case? The way this is used in the shader I think this could cause a float-int mismatch error.
There was a problem hiding this comment.
^ Not outdated, despite what github says
There was a problem hiding this comment.
I had not!. Good one. Thanks @karimnaaji .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
texture