Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fractional dashed line patterns #951

Closed
karimnaaji opened this issue Sep 2, 2016 · 1 comment · Fixed by #1249
Closed

Allow fractional dashed line patterns #951

karimnaaji opened this issue Sep 2, 2016 · 1 comment · Fixed by #1249

Comments

@karimnaaji
Copy link
Member

Follow up for tangrams/tangram#404.

@matteblair
Copy link
Member

This is being used in walkabout-style now: https://github.com/tangrams/walkabout-style/blob/gh-pages/walkabout-style.yaml#L875-L890 so these styles are currently not rendering in tangram-es :\

@tallytalwar tallytalwar self-assigned this Jan 24, 2017
tallytalwar added a commit that referenced this issue Jan 25, 2017
- Parse float values
- Scale dash values with a fixed scale factor "20" (In accordance with JS) before filling the dash
texture
- Make sure to adjust texture coordinate to account for the texture data
- fixes #951
karimnaaji pushed a commit that referenced this issue Jan 27, 2017
- Parse float values
- Scale dash values with a fixed scale factor "20" (In accordance with JS) before filling the dash
texture
- Make sure to adjust texture coordinate to account for the texture data
- fixes #951
karimnaaji pushed a commit that referenced this issue Jan 27, 2017
* Allow float values for dash parameter

- Parse float values
- Scale dash values with a fixed scale factor "20" (In accordance with JS) before filling the dash
texture
- Make sure to adjust texture coordinate to account for the texture data
- fixes #951

* Add missing CR to shader defines

* Set define value to float
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants