Build Android native libraries through Gradle #1152

matteblair · 2016-12-08T19:21:50Z

Android Studio 2.2 and the associated Gradle components now include a mechanism to execute "external native builds" via CMake. This enables us to build all pieces of our Android SDK, including the native libraries, from a Gradle command. This also allows us to use the latest versions of the Android NDK, which are incompatible with our old Android build system.

matteblair · 2016-12-08T19:54:57Z

Ignore this PR for now - I've got some wrestling to do with Travis CI.

Edit: CI is working correctly now.

tallytalwar · 2016-12-09T01:30:43Z

android/tangram/build.gradle

+      // Default configuration
+    }
+    full {
+      externalNativeBuild.cmake.abiFilters 'armeabi', 'arm64-v8a', 'x86'


Should we also be including armv7 or its picked up by default?

I said to ignore this PR! ;)

I was unsure about this too, but empirically it seems to pick up armeabi-v7a from the default configuration.

Can not hold a man for his curiosity :).

matteblair · 2016-12-13T00:05:02Z

Ready for review now! Before merging, though, we should merge tangrams/yaml-cpp#8 and use the normal tangram branch of yaml-cpp here. I've also dropped Travis builds for iOS and macOS, in anticipation of moving those to CircleCI.

Edit: This has been done now.

matteblair · 2016-12-19T16:05:29Z

Ping @tallytalwar & @hjanetzek for review

tallytalwar

Mostly good. Have some small questions, I have asked in this review.

Also we can probably squash a bunch of commits here.

tallytalwar · 2016-12-19T19:54:58Z

android/tangram/build.gradle

+      cmake {
+        targets 'tangram'
+        arguments '-DPLATFORM_TARGET=android',
+                  '-DANDROID_TOOLCHAIN=clang',


clang is the default toolchain as per the docs, do we need to be explicit here?

clang became the default very recently - I would prefer to leave this here in case someone is using an NDK from before that change.

tallytalwar · 2016-12-19T19:57:14Z

android/tangram/build.gradle

+        arguments '-DPLATFORM_TARGET=android',
+                  '-DANDROID_TOOLCHAIN=clang',
+                  '-DANDROID_STL=c++_shared'
+        cppFlags '-std=c++14',


based on the docs, we might also need -latomic here.

https://developer.android.com/ndk/guides/cpp-support.html

I suppose it couldn't hurt, though there are no runtime errors produced by using things from the <atomic> headers so it's unclear whether it is necessary.

Yup I saw when I build, it did not complain. But I would link atomic only because documentation is suggesting it.

atomic is linked in android.cmake now.

tallytalwar · 2016-12-19T20:22:29Z

android/demo/build.gradle

    assets.srcDirs = ['../../scenes']
  }
-  buildTypes {


Any specific issues here with the debug configuration? Based on b859576, it seems it was only temporary.

tallytalwar · 2016-12-19T20:29:18Z

android/demo/build.gradle

-  buildTypes {
-    debug {
-      // applicationIdSuffix ".debug"
-      jniDebuggable true


Should'nt the demo app be marked debuggable?

This is a good point about the "debuggable" flags, I'm not sure of the impact of these flags on either the library or demo module under the new build system, but I can try both and see.

tallytalwar · 2016-12-19T21:05:10Z

scripts/travis/script_deploy_android_snapshot.sh

-    #make android-native-lib ANDROID_ARCH=x86_64
-    #make android-native-lib ANDROID_ARCH=mips
-    #make android-native-lib ANDROID_ARCH=mips64
+    make android-sdk


So previously arm7l was done during the default build process and other architecture were build only during deployment.

It seems this will build, everything again including arm7l (in other words, arm7l will be builds twice).

The arm7l target will be up-to-date when we encounter it the second time, so nothing needs to be done.

tallytalwar · 2016-12-19T21:07:18Z

android/tangram/build.gradle

+    }
+    debug {
+      externalNativeBuild {
+        cmake.arguments '-DCMAKE_BUILD_TYPE=Debug'


Do these take care of debugging for demo app and also debugging on the device, which was disabled here: b859576

matteblair · 2016-12-20T17:16:22Z

I've set up debug configurations for the library and demo app in a way that should allow debugging native code - that is, I've tested the same configuration in a minimal test project and was able to debug native code fro Android studio. However, I have not been able to successfully debug native code from Android Studio yet. Any further ideas are welcome!

matteblair · 2016-12-20T17:24:12Z

I could squash more of these commits together, but there are actually quite a lot of distinctly meaningful changes here, despite the low number of lines added. I'd rather have many commits that describe these changes in accurate detail.

matteblair · 2016-12-21T16:34:03Z

~ Ping for review approval ~

- add jcenter() repository - update android-maven-gradle-plugin to 1.5 - update Android Gradle plugin to 2.2.3 - move 'buildscript.dependencies' to project Gradle config

- download NDK r13b

This may let us use CI machines with more disk space

Also add debug flags for demo app debug configuration

matteblair · 2016-12-22T20:03:48Z

@tallytalwar Can you check over the updated README and merge this when you get a chance?

tallytalwar

Looks good to me. Merging.

matteblair force-pushed the android-cmake branch from b30004c to 1aa32f4 Compare December 8, 2016 19:37

matteblair force-pushed the android-cmake branch 4 times, most recently from 9a180d1 to 4395f8a Compare December 8, 2016 21:18

tallytalwar reviewed Dec 9, 2016

View reviewed changes

matteblair force-pushed the android-cmake branch 6 times, most recently from d808c39 to 204f748 Compare December 12, 2016 23:36

matteblair added the ready for review label Dec 13, 2016

matteblair requested review from hjanetzek and tallytalwar December 13, 2016 00:07

matteblair force-pushed the android-cmake branch 5 times, most recently from de3855d to 7afaf7e Compare December 19, 2016 16:04

tallytalwar requested changes Dec 19, 2016

View reviewed changes

matteblair force-pushed the android-cmake branch from 7afaf7e to 850a076 Compare December 20, 2016 17:02

matteblair force-pushed the android-cmake branch from 850a076 to 0ecb7c4 Compare December 20, 2016 17:18

matteblair force-pushed the android-cmake branch from 0ecb7c4 to bc6f13f Compare December 21, 2016 16:33

matteblair added 13 commits December 22, 2016 13:24

Update Gradle build dependencies in Android SDK and demo

6f8c405

- add jcenter() repository - update android-maven-gradle-plugin to 1.5 - update Android Gradle plugin to 2.2.3 - move 'buildscript.dependencies' to project Gradle config

Add 'externalNativeBuild' configuration to Android SDK Gradle script

9e7353f

Remove NDK toolchain checks and debugging config from android.cmake

578563a

Remove android.toolchain.cmake, no longer needed

f0de40c

Move cpp compile flags into Android SDK build.gradle

991ddc9

Update Makefile for gradle cmake Android build

3a81038

Remove mindk installation on travis

1fa6600

Add NDK download step to travis

eb78365

- download NDK r13b

Add step to download Android CMake package on Travis

43f52a1

Increase Gradle JVM heap size to 2048MB

3afa794

Update Android target API to 25

0cc0176

Remove custom Android debug configs

5725dfb

Remove custom library output locations for Android

f053534

matteblair force-pushed the android-cmake branch from 7c15c5c to ab5e4ec Compare December 22, 2016 18:25

matteblair added 9 commits December 22, 2016 15:02

Move Android sources into standard locations

b86b23f

Use 'sudo: enabled' travis config

44784e1

This may let us use CI machines with more disk space

Update Android dependencies for Travis

d77bc87

Copy a license file for Android components on travis

5fe223a

Clean up travis apt packages for Android

e2625e1

Add 'slim' and 'full' configurations for Android SDK

54f4b13

Also add debug flags for demo app debug configuration

Update CI scripts for new Android build commands

b3a4c1a

Add '-g' cpp flag to android debug builds

4380917

Update Android build instructions in README

52b16fe

matteblair force-pushed the android-cmake branch from ab5e4ec to 52b16fe Compare December 22, 2016 20:03

tallytalwar approved these changes Dec 22, 2016

View reviewed changes

tallytalwar merged commit 8c24e75 into master Dec 22, 2016

tallytalwar deleted the android-cmake branch December 22, 2016 20:31

This was referenced Jan 10, 2017

Move android toolchain to use r11 #625

Closed

Building tangram-es with new android studio 2.2 with cmake support #807

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Android native libraries through Gradle #1152

Build Android native libraries through Gradle #1152

matteblair commented Dec 8, 2016

matteblair commented Dec 8, 2016 •

edited

Loading

tallytalwar Dec 9, 2016

matteblair Dec 9, 2016

tallytalwar Dec 9, 2016

matteblair commented Dec 13, 2016 •

edited

Loading

matteblair commented Dec 19, 2016

tallytalwar left a comment

tallytalwar Dec 19, 2016

matteblair Dec 19, 2016

tallytalwar Dec 19, 2016

tallytalwar Dec 19, 2016

matteblair Dec 19, 2016

tallytalwar Dec 19, 2016

matteblair Dec 20, 2016

tallytalwar Dec 19, 2016

tallytalwar Dec 19, 2016

matteblair Dec 19, 2016

tallytalwar Dec 19, 2016

matteblair Dec 19, 2016

tallytalwar Dec 19, 2016

matteblair commented Dec 20, 2016

matteblair commented Dec 20, 2016

matteblair commented Dec 21, 2016

matteblair commented Dec 22, 2016

tallytalwar left a comment

Build Android native libraries through Gradle #1152

Build Android native libraries through Gradle #1152

Conversation

matteblair commented Dec 8, 2016

matteblair commented Dec 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matteblair commented Dec 13, 2016 • edited Loading

matteblair commented Dec 19, 2016

tallytalwar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matteblair commented Dec 20, 2016

matteblair commented Dec 20, 2016

matteblair commented Dec 21, 2016

matteblair commented Dec 22, 2016

tallytalwar left a comment

Choose a reason for hiding this comment

matteblair commented Dec 8, 2016 •

edited

Loading

matteblair commented Dec 13, 2016 •

edited

Loading