Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move android toolchain to use r11 #625

Closed
tallytalwar opened this issue Mar 14, 2016 · 5 comments
Closed

Move android toolchain to use r11 #625

tallytalwar opened this issue Mar 14, 2016 · 5 comments
Labels

Comments

@tallytalwar
Copy link
Member

Android ndk got upgraded to r11. Tangram-es is currently using r10e.

Update to use r11.
http://developer.android.com/ndk/downloads/index.html

@tallytalwar tallytalwar self-assigned this Apr 6, 2016
@tallytalwar
Copy link
Member Author

So they changed the entire directory structure in r11(a/b/c), plus moved clang toolchains from {NDK_ROOT}/toolchains to {NDK_ROOT}/build/core/toolchains. They also got rid of old clang toolchains. Apparently, all of these changes mean we can not directly (or with minimal change/work) use our present android.toolchain.cmake. A lot of work will be required to bring android.toolchain.cmake to work with ndk-r11* releases.

On the other hand, we should definitely find more robust way of bypassing this android.toolchain.cmake.

I am going to park this issue for the time being, or until we have a pressing reason to move to a newer ndk release.

Refer: taka-no-me/android-cmake#81, (this also have some hacky way of getting the toolchain to work, but I do not think we should adopt this approach).

@tallytalwar tallytalwar removed their assignment Apr 9, 2016
@matteblair
Copy link
Member

Fascinating! Makes sense to put this on standby.

Part of me would like to use the ndk-build script that comes with the NDK, then we could be sure that future versions of the NDK would continue to work. The trick would just be figuring out how to interface with the weird makefile-like inputs to ndk-build.

Or we could move everything to Bazel! ;)

@karimnaaji
Copy link
Member

karimnaaji commented May 19, 2016

Doing some research over that, it seems that this project have an updated version using r11 in their cmake toolchain https://github.com/urho3d/Urho3D. It would be worth trying this before investing more work towards moving to a different build system for android.

@matteblair
Copy link
Member

Android Studio 2.2 supports CMake integration out of the box, we should wait until it's released and use that for our build toolchain instead: http://tools.android.com/recent/androidstudio22preview3available

@tallytalwar
Copy link
Member Author

tallytalwar commented Jan 10, 2017

Our android build system is through new android studio and using gradle native builds, which will make sure we are upto date with NDK versions.
Refer: #1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants