Fix custom CMake tasks for tools besides 'make' #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.
hjanetzek
pushed a commit
that referenced
this pull request
Sep 18, 2018
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.
hjanetzek
pushed a commit
that referenced
this pull request
Nov 18, 2018
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.
hjanetzek
pushed a commit
that referenced
this pull request
Nov 19, 2018
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.
hjanetzek
pushed a commit
that referenced
this pull request
Nov 29, 2018
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional that was here incorrectly accepts tools that have 'make' anywhere in their path (with Android Studio, the ninja binary is in a folder called 'cmake'). This change makes these targets correct for build tools other than 'make'.