Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-doc): prevent convert invalid number to NaN #3528

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3474

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 27, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 27, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
333.97KB (-11B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.9KB +10%
demo/browser/runtime.(hash).js
35.14KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -11B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (-11B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023

Visit the preview URL for this PR (updated for commit c436377):

https://taiga-ui--pr3528-splincode-fix-issues-vhiktoml.web.app

(expires Sat, 28 Jan 2023 12:56:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/fix/issues/3474 branch from 61fbef1 to c436377 Compare January 27, 2023 12:53
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 68.20% // Head: 68.20% // No change to project coverage 👍

Coverage data is based on head (c436377) compared to base (02b8a0b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3528   +/-   ##
=======================================
  Coverage   68.20%   68.20%           
=======================================
  Files        1142     1142           
  Lines       13768    13768           
  Branches     1917     1918    +1     
=======================================
  Hits         9390     9390           
  Misses       4050     4050           
  Partials      328      328           
Flag Coverage Δ
addon-charts 71.87% <ø> (ø)
addon-doc 49.81% <100.00%> (ø)
addon-editor 50.29% <ø> (ø)
addon-mobile 61.73% <ø> (ø)
addon-table 60.61% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk ∅ <ø> (∅)
core 76.84% <ø> (ø)
kit 72.91% <ø> (ø)
summary 68.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/addon-doc/src/utils/coerce-value.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 6e259f4 into main Jan 30, 2023
@splincode splincode deleted the splincode/fix/issues/3474 branch January 30, 2023 14:21
@well-done-bot
Copy link

well-done-bot bot commented Jan 30, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - TuiDocDocumentationPropertyConnectorDirective incorrectly parses dot from query params
3 participants