Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-doc): prevent convert invalid number to NaN #3528

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(addon-doc): prevent convert invalid number to NaN #3528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions projects/addon-doc/src/utils/coerce-value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ function isBooleanParamValue(value: string): boolean {
}

function isNumberParamValue(value: string): boolean {
// TODO: investigate to disallow potentially catastrophic exponential-time regular expressions.
// eslint-disable-next-line unicorn/no-unsafe-regex
return /^-?[\d.]+(?:e-?\d+)?$/.test(value);
return !!value.trim() && !Number.isNaN(Number(value)) && !value.startsWith(`+`);
}

function isPossibleArray(value: string): boolean {
Expand Down
10 changes: 10 additions & 0 deletions projects/addon-doc/src/utils/test/coerce-value.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,21 @@ describe(`coercing values`, () => {
expect(tuiCoerceValue(`Hello world`)).toBe(`Hello world`);
expect(tuiCoerceValue(`2+5`)).toBe(`2+5`);
expect(tuiCoerceValue(``)).toBe(``);
expect(tuiCoerceValue(` `)).toBe(``);
});

it(`string -> number`, () => {
expect(tuiCoerceValue(`123`)).toBe(123);
expect(tuiCoerceValue(`-123`)).toBe(-123);
expect(tuiCoerceValue(`.2`)).toBe(0.2);
expect(tuiCoerceValue(`-.2`)).toBe(-0.2);
expect(tuiCoerceValue(`2e5`)).toBe(200000);

expect(tuiCoerceValue(`.`)).not.toBeInstanceOf(Number);
expect(tuiCoerceValue(`1,2`)).not.toBeInstanceOf(Number);
expect(tuiCoerceValue(`abc`)).not.toBeInstanceOf(Number);
expect(tuiCoerceValue(`1+2`)).not.toBeInstanceOf(Number);
expect(tuiCoerceValue(` 123 `)).not.toBeInstanceOf(Number);
});

it(`string -> boolean`, () => {
Expand Down