fix(addon-doc): prevent convert invalid number to NaN

taiga-family · Jan 27, 2023 · c436377 · c436377
1 parent 02b8a0b
commit c436377
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/projects/addon-doc/src/utils/coerce-value.ts b/projects/addon-doc/src/utils/coerce-value.ts
@@ -35,9 +35,7 @@ function isBooleanParamValue(value: string): boolean {
 }
 
 function isNumberParamValue(value: string): boolean {
-    // TODO: investigate to disallow potentially catastrophic exponential-time regular expressions.
-    // eslint-disable-next-line unicorn/no-unsafe-regex
-    return /^-?[\d.]+(?:e-?\d+)?$/.test(value);
+    return !!value.trim() && !Number.isNaN(Number(value)) && !value.startsWith(`+`);
 }
 
 function isPossibleArray(value: string): boolean {

diff --git a/projects/addon-doc/src/utils/test/coerce-value.spec.ts b/projects/addon-doc/src/utils/test/coerce-value.spec.ts
@@ -8,11 +8,21 @@ describe(`coercing values`, () => {
         expect(tuiCoerceValue(`Hello world`)).toBe(`Hello world`);
         expect(tuiCoerceValue(`2+5`)).toBe(`2+5`);
         expect(tuiCoerceValue(``)).toBe(``);
+        expect(tuiCoerceValue(`    `)).toBe(``);
     });
 
     it(`string -> number`, () => {
         expect(tuiCoerceValue(`123`)).toBe(123);
         expect(tuiCoerceValue(`-123`)).toBe(-123);
+        expect(tuiCoerceValue(`.2`)).toBe(0.2);
+        expect(tuiCoerceValue(`-.2`)).toBe(-0.2);
+        expect(tuiCoerceValue(`2e5`)).toBe(200000);
+
+        expect(tuiCoerceValue(`.`)).not.toBeInstanceOf(Number);
+        expect(tuiCoerceValue(`1,2`)).not.toBeInstanceOf(Number);
+        expect(tuiCoerceValue(`abc`)).not.toBeInstanceOf(Number);
+        expect(tuiCoerceValue(`1+2`)).not.toBeInstanceOf(Number);
+        expect(tuiCoerceValue(`   123   `)).not.toBeInstanceOf(Number);
     });
 
     it(`string -> boolean`, () => {