Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type-declaration-related rules to type-perfect package #128

Merged
merged 11 commits into from
May 27, 2024

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 27, 2024

Scope of this ruleset is over 40+ rules, with different ares of focus. That's hard to grasp as "phpstan-rules" package name doesn't give a hint. This is part of simplification process to narrow rules into smaller more meaningful packages.


These rules were only moved to https://github.com/rectorphp/type-perfect and further improved there 👍
That way you can install the type-perfect package with clear goal to improve type coverage 😉

  • remove NoArrayAccessOnObjectRule, moved to new rector/type-perfect package
  • remove NoIssetOnObjectRule, moved to new rector/type-perfect package
  • remove ForbiddenParamTypeRemovalRule, moved to new rector/type-perfect package
  • remove NoMixedMethodCallerRule, moved to new rector/type-perfect package
  • remove NoMixedPropertyFetcherRule, moved to new rector/type-perfect package
  • remove RequireSpecificReturnTypeOverAbstractRule, moved to new rector/type-perfect package
  • remove NoReturnFalseInNonBoolClassMethodRule, moved to new rector/type-perfect package
  • remove NarrowPublicClassMethodParamTypeByCallerTypeRule, moved to new rector/type-perfect package
  • remove unused services
  • remove CheckTypehintCallerTypeRule, moved to new rector/type-perfect package

@TomasVotruba TomasVotruba changed the title tv outsource type perfect rules Move type-declaration-related rules to type-perfect package May 27, 2024
@TomasVotruba TomasVotruba merged commit ad83c89 into main May 27, 2024
6 checks passed
@TomasVotruba TomasVotruba deleted the tv-outsource-type-perfect-rules branch May 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant