Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMixed rules where super useful #138

Closed
dereuromark opened this issue Jul 5, 2024 · 4 comments
Closed

NoMixed rules where super useful #138

dereuromark opened this issue Jul 5, 2024 · 4 comments

Comments

@dereuromark
Copy link

I am a bit sad that the only things we used:

rules:
- Symplify\PHPStanRules\Rules\Explicit\NoMixedPropertyFetcherRule
- Symplify\PHPStanRules\Rules\Explicit\NoMixedMethodCallerRule

Are both removed in v13 forward

You might not have used them much, but others might have.
Is there any way those could be supported as ext package maybe? Like phpstan-rules-ext as opt-in?
This way we could continue using them without having to maintain PHPStan rulesets ourselves.

They are superuseful in showing where methods, variables and properties are not clear and thus the following code not properly PHPStan asserted, since with mixed it will just be silent.

@TomasVotruba
Copy link
Member

Don't worry, they're still here :) just in a smaller decopuled package with improved functionality

See #128
And https://getrector.com/blog/introducing-type-perfect-for-extra-safety

@TomasVotruba
Copy link
Member

Make sure you're subscribed to release notes here, so you won't miss important info
https://github.com/symplify/phpstan-rules/releases

@dereuromark
Copy link
Author

dereuromark commented Jul 5, 2024

Something is still weird, though

Before, I activated them manually - and I could silence them using (with new names)

#- Rector\TypePerfect\Rules\NoMixedPropertyFetcherRule
#- Rector\TypePerfect\Rules\NoMixedMethodCallerRule

inside phpstan.neon

This is now not possible anymore with the new way. They are always active by default.

@TomasVotruba
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants