Move type-declaration-related rules to type-perfect package (#128)

* remove NoArrayAccessOnObjectRule, moved to new rector/type-perfect package * remove NoIssetOnObjectRule, moved to new rector/type-perfect package * remove ForbiddenParamTypeRemovalRule, moved to new rector/type-perfect package * remove NoMixedMethodCallerRule, moved to new rector/type-perfect package * remove NoMixedPropertyFetcherRule, moved to new rector/type-perfect package * remove RequireSpecificReturnTypeOverAbstractRule, moved to new rector/type-perfect package * remove NoReturnFalseInNonBoolClassMethodRule, moved to new rector/type-perfect package * remove NarrowPublicClassMethodParamTypeByCallerTypeRule, moved to new rector/type-perfect package * remove unused services * remove CheckTypehintCallerTypeRule, moved to new rector/type-perfect package * sets
symplify · May 27, 2024 · ad83c89 · ad83c89
1 parent 9213f3c
commit ad83c89
Show file tree

Hide file tree

Showing 156 changed files with 0 additions and 4,391 deletions.
diff --git a/README.md b/README.md
@@ -25,7 +25,6 @@ Sets are bunch of rules grouped by a common area, e.g. improve naming. You can p
 ```yaml
 includes:
     - vendor/symplify/phpstan-rules/config/code-complexity-rules.neon
-    - vendor/symplify/phpstan-rules/config/collector-rules.neon
     - vendor/symplify/phpstan-rules/config/naming-rules.neon
     - vendor/symplify/phpstan-rules/config/regex-rules.neon
     - vendor/symplify/phpstan-rules/config/static-rules.neon

diff --git a/config/code-complexity-rules.neon b/config/code-complexity-rules.neon
@@ -1,5 +1,3 @@
 rules:
-    - Symplify\PHPStanRules\Rules\Explicit\NoMixedPropertyFetcherRule
-    - Symplify\PHPStanRules\Rules\Explicit\NoMixedMethodCallerRule
     - Symplify\PHPStanRules\Rules\NoDynamicNameRule
     - Symplify\PHPStanRules\Rules\NoReturnArrayVariableListRule
diff --git a/config/collector-rules.neon b/config/collector-rules.neon
diff --git a/config/naming-rules.neon b/config/naming-rules.neon
@@ -3,5 +3,4 @@ rules:
     - Symplify\PHPStanRules\Rules\NoReturnSetterMethodRule
     - Symplify\PHPStanRules\Rules\UppercaseConstantRule
     - Symplify\PHPStanRules\Rules\ClassNameRespectsParentSuffixRule
-    - Symplify\PHPStanRules\Rules\CheckTypehintCallerTypeRule
     - Symplify\PHPStanRules\Rules\CheckClassNamespaceFollowPsr4Rule
diff --git a/config/services/services.neon b/config/services/services.neon
@@ -17,16 +17,7 @@ services:
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\RegexFuncCallAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\RegexStaticCallAnalyzer
-    - Symplify\PHPStanRules\NodeFinder\ClassMethodNodeFinder
-    - Symplify\PHPStanRules\NodeFinder\MethodCallNodeFinder
-    - Symplify\PHPStanRules\NodeFinder\ReturnNodeFinder
     - Symplify\PHPStanRules\ParentClassMethodNodeResolver
-    - Symplify\PHPStanRules\PhpDoc\ApiDocStmtAnalyzer
     - Symplify\PHPStanRules\PhpDoc\BarePhpDocParser
     - Symplify\PHPStanRules\PhpDoc\PhpDocResolver
-    - Symplify\PHPStanRules\Printer\NodeComparator
-    - Symplify\PHPStanRules\Reflection\MethodNodeAnalyser
     - Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer
-    - Symplify\PHPStanRules\Matcher\Collector\PublicClassMethodMatcher
-    - Symplify\PHPStanRules\Matcher\ClassMethodCallReferenceResolver
-    - Symplify\PHPStanRules\Printer\CollectorMetadataPrinter
diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -5,24 +5,17 @@ rules:
     - Symplify\PHPStanRules\Rules\Domain\RequireExceptionNamespaceRule
     - Symplify\PHPStanRules\Rules\Domain\RequireAttributeNamespaceRule
     - Symplify\PHPStanRules\Rules\Enum\RequireUniqueEnumConstantRule
-    - Symplify\PHPStanRules\Rules\ForbiddenParamTypeRemovalRule
     - Symplify\PHPStanRules\Rules\PreventParentMethodVisibilityOverrideRule
 
     # paths
     - Symplify\PHPStanRules\Rules\NoMissingDirPathRule
     - Symplify\PHPStanRules\Rules\NoReferenceRule
-    - Symplify\PHPStanRules\Rules\NoArrayAccessOnObjectRule
 
     - Symplify\PHPStanRules\Rules\NoNullableArrayPropertyRule
 
-    # dead-code
-    - Symplify\PHPStanRules\Rules\NoIssetOnObjectRule
-
     # explicit naming
     - Symplify\PHPStanRules\Rules\ForbiddenMultipleClassLikeInOneFileRule
 
-    # comlexity
-    - Symplify\PHPStanRules\Rules\NarrowType\NoReturnFalseInNonBoolClassMethodRule
 
     - Symplify\PHPStanRules\Rules\Complexity\ForbiddenArrayMethodCallRule
     - Symplify\PHPStanRules\Rules\CheckRequiredInterfaceInContractNamespaceRule

diff --git a/config/symplify-rules.neon b/config/symplify-rules.neon
@@ -1,6 +1,5 @@
 includes:
     - code-complexity-rules.neon
-    - collector-rules.neon
     - configurable-rules.neon
     - naming-rules.neon
     - regex-rules.neon

diff --git a/phpstan.neon b/phpstan.neon
@@ -34,7 +34,6 @@ parameters:
 
         # needless generics
         - '#Class Symplify\\PHPStanRules\\(.*?)Rule implements generic interface PHPStan\\Rules\\Rule but does not specify its types\: TNodeType#'
-        - '#Method (.*?)::getCollectors\(\) return type with generic interface PHPStan\\Collectors\\Collector does not specify its types\: TNodeType, TValue#'
 
         - '#Parameter \#1 \$values of method Symplify\\PHPStanRules\\Rules\\Enum\\RequireUniqueEnumConstantRule\:\:filterDuplicatedValues\(\) expects array<int\|string>, array<bool\|float\|int\|string> given#'
 
@@ -44,8 +43,6 @@ parameters:
 
         - '#Method Symplify\\PHPStanRules\\NodeFinder\\TypeAwareNodeFinder\:\:findFirstInstanceOf\(\) should return \(TNode of PhpParser\\Node\)\|null but returns PhpParser\\Node\|null#'
 
-        - '#Method Symplify\\PHPStanRules\\NodeFinder\\MethodCallNodeFinder\:\:findUsages\(\) should return array<PhpParser\\Node\\Expr\\MethodCall> but returns array<PhpParser\\Node>#'
-
         # overly detailed
         - '#Class Symplify\\PHPStanRules\\(.*?) extends generic class PHPStan\\Testing\\RuleTestCase but does not specify its types\: TRule#'
         - '#Method Symplify\\PHPStanRules\\(.*?)\:\:getRule\(\) return type with generic interface PHPStan\\Rules\\Rule does not specify its types\: TNodeType#'

diff --git a/src/Collector/ClassMethod/PublicClassMethodParamTypesCollector.php b/src/Collector/ClassMethod/PublicClassMethodParamTypesCollector.php
diff --git a/src/Collector/MethodCall/MethodCallArgTypesCollector.php b/src/Collector/MethodCall/MethodCallArgTypesCollector.php
diff --git a/src/Collector/MethodCallableNode/MethodCallableCollector.php b/src/Collector/MethodCallableNode/MethodCallableCollector.php
diff --git a/src/Enum/Types/ResolvedTypes.php b/src/Enum/Types/ResolvedTypes.php
diff --git a/src/Matcher/ClassMethodCallReferenceResolver.php b/src/Matcher/ClassMethodCallReferenceResolver.php