Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to override vendor directory location #4642

Closed
wants to merge 4,467 commits into from
Closed

How to override vendor directory location #4642

wants to merge 4,467 commits into from

Conversation

gajdaw
Copy link
Contributor

@gajdaw gajdaw commented Dec 13, 2014

Hi,
I have found this solution extremely efficient when working on Vagrant/Windows.
Maybe others will find it interesting too.

I have tested it in Symfony 2.3 only, so I am not sure if it applies to all other versions.

Q A
Doc fix? [no]
New docs? [no]
Applies to [Symfony 2.3]
Fixed tickets [-]

weaverryan and others added 30 commits October 29, 2014 08:23
…te Helper is (iltar)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4344).

Discussion
----------

[Templating] Added a sentence that explains what a Template Helper is

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | n/a

I found a SecurityHelper in the SecurityBundle. I was unsure what this helper was or what it was supposed to do. After some googling I've landed on the templating component documation. This is correct as the `HelperInterface` can be found in [the component](http://symfony.com/doc/current/components/templating/introduction.html#helpers). However, it doesn't explain what a helper is.

After some searching, [the cookbook *does* explain what a helper is](http://symfony.com/doc/current/cookbook/templating/PHP.html#using-template-helpers). I've pretty much copied over the sentence from the cookbook to the component. If you have a better proposal, I can add that instead.

Commits
-------

6cdecde [Templating] Added a sentence that explains what a Template Helper is
…on paragraphs (arnaugm)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove incoherence between Doctrine and Propel introduction paragraphs

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4349

The introductory paragraph of Doctrine and Propel sections, although both are true in some way, look contradictory, so a rephrase of at least one of the two paragraphs would be convenient.

Commits
-------

7992fdf Remove incoherence between Doctrine and Propel introduction paragraphs
This PR was merged into the 2.3 branch.

Discussion
----------

Updated Valid constraint reference

| Q              | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Revised PR #4351 for 2.3 branch

Commits
-------

a50bb96 Updated Valid constraint reference
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4388).

Discussion
----------

Minor spelling fix

http://www.oxforddictionaries.com/definition/english/ground

Commits
-------

ef3a58e Minor spelling fix
This re-adds PR #4280, which was temporarily reverted while we waited
for the proper PHP extensions.
…ed forms to Valid... (peterrehm)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4348).

Discussion
----------

Updated information about handling validation of embedded forms to Valid...

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4346

Applied Valid constraint instead of the cascade_validation option since this option is supposed to be deprecated with symfony/symfony#12237

Commits
-------

b699731 Updated information about handling validation of embedded forms to Valid constraint
This PR was merged into the 2.3 branch.

Discussion
----------

update Sphinx extension submodule reference

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

5ca2df8 update Sphinx extension submodule reference
This reverts commit 23afdb3.

We thought we had the issue fixed, but apparently not quite yet - see #4280
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer.
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4375).

Discussion
----------

Removed the redundant usage of layer.

Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header.

Commits
-------

27339c7 One more again. I could have sworn I had them lined up.
84164fa Removed the possession from Doctrine.
693698e Shorten the = to match the length of the text.
5ea2902 Removed the redundant usage of layer.
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4387).

Discussion
----------

Inline condition removed for easier reading

Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)

Commits
-------

b98f5e8 Inline condition removed for easier reading
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4396).

Discussion
----------

Corrected latin abbreviation

i.e. = *id est*, “that is”
e.g. = *exempli gratia*, “for example”

Commits
-------

be86ab6 Yay for latin abbreviations
It seems like this one was missed when reverting the change. For the
discussion, see #4290
"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config

   requirements: 
        name: .+
weaverryan and others added 14 commits December 7, 2014 19:05
there are references to "--dev" composer parameter that is the
current default value.
…nit tests, (carlosbuenosvinos)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4585).

Discussion
----------

When explaining how to install dependencies for running unit tests,

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4584

Commits
-------

512632e When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |
This PR was merged into the 2.3 branch.

Discussion
----------

[Best Practices] readd mistakenly removed label

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

The button was mistakenly removed in c090a74.

Commits
-------

eabcc59 readd mistakenly removed label
This PR was merged into the 2.3 branch.

Discussion
----------

[Contributing] fix feature freeze dates

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4510

Commits
-------

8f25a15 fix feature freeze dates
This PR was merged into the 2.3 branch.

Discussion
----------

Change refering block name from content to body

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

5c0ceff Change refering block name from content to body
…buh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] filesystem headlines match method names

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4450

Commits
-------

9d77a6d filesystem headlines match method names
This PR was merged into the 2.3 branch.

Discussion
----------

[OptionsResolver] Fix Namespace link

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #4620

Commits
-------

fc43571 [OptionsResolver] Fix Namespace link
Currently all of the titles in Console section use gerund, but not this one.
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4625).

Discussion
----------

Added '-ing' title ending to unify titles look

Currently all of the titles in Console section use gerund, but not this one.

Commits
-------

74b75de Added '-ing' title ending to unify titles look
}

In ``app/autoload.php`` you need to modify the path leading to
``vendor/autoload.php`` file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a double colon.

@gajdaw
Copy link
Contributor Author

gajdaw commented Dec 13, 2014

Hi WouterJ,
Thanks for your help. I introduced all your suggestions.

@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

It looks great! Thanks for your quick response, @gajdaw!

Now we just have to wait till @weaverryan hits the merge button.

@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

Btw, can you please rebase on 2.3. 2.0, 2.1 and 2.2 are no longer maintained.

@gajdaw
Copy link
Contributor Author

gajdaw commented Dec 13, 2014

I have just rebased it against 2.3 branch. But I cannot change the destination branch in pull request.

@gajdaw gajdaw closed this Dec 13, 2014
weaverryan added a commit that referenced this pull request Jan 16, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

How to override vendor directory location

| Q             | A
| ------------- | ---
| Doc fix?      | [no]
| New docs?     | [no]
| Applies to    | [Symfony 2.3]
| Fixed tickets | [#4642]

Commits
-------

0875bd8 How to override vendor directory location - fix
07f6843 How to override vendor directory location - fix
bce4c16 How to override vendor directory location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.