How to override vendor directory location #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gajdaw
commented
Dec 13, 2014
gajdaw
commented
| Q | A |
|---|---|
| Doc fix? | [no] |
| New docs? | [no] |
| Applies to | [Symfony 2.3] |
| Fixed tickets | [#4642] |
| --------------------------------- | ||
|
|
||
| To override the ``vendor`` directory you have to introduce changes | ||
| in the following files: |
There was a problem hiding this comment.
It seems to me that you break lines too early. It's sufficient to add a newline after the first word that crosses the 72nd character (same below).
|
@xabbuh I have reformatted the commit. |
| // app/autoload.php | ||
| /** | ||
| * @var ClassLoader $loader | ||
| */ |
There was a problem hiding this comment.
Do we really need the docblock here?
There was a problem hiding this comment.
@xabbuh You are right. This is completely unnecessary.
|
@gajdaw Looks good to me. I just left a last comment. |
| file:: | ||
|
|
||
| // app/autoload.php | ||
|
|
There was a problem hiding this comment.
now you just need to remove this empty line and everything is ok. Thanks for your quick action each time!
|
shoulnd this contributed to composers documentation and just linked? |
|
@timglabisch Because of the change in Composer's doc contains info about |
|
@wouterj I think its finished. |
|
Very nice - thanks Włodzimierz! |
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
This PR was merged into the 2.3 branch. Discussion ---------- How to override vendor directory location | Q | A | ------------- | --- | Doc fix? | [no] | New docs? | [no] | Applies to | [Symfony 2.3] | Fixed tickets | [#4642] Commits ------- 0875bd8 How to override vendor directory location - fix 07f6843 How to override vendor directory location - fix bce4c16 How to override vendor directory location
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
* 2.3: [#4857] Adding missing word thanks to xabbuh Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Removed a leftover comma in security config sample [#4141] Tweaks to the new form csrf caching entry How to override vendor directory location - fix How to override vendor directory location - fix How to override vendor directory location
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
* 2.5: [#4857] Adding missing word thanks to xabbuh Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix code example Removed a leftover comma in security config sample [#4141] Tweaks to the new form csrf caching entry How to override vendor directory location - fix How to override vendor directory location - fix How to override vendor directory location
weaverryan
added a commit
that referenced
this pull request
Jan 18, 2015
* 2.6: (30 commits) fix merge after removing @Security in 2.3 Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge) [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it Typo Fix: "allows to" should be "allows you to" Adding a link to log things in the prod environment [#4857] Adding missing word thanks to xabbuh move cautions to make them visible Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz language tweak thanks to xabbuh! Adding an example image of the debug_formatter [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix typo: BLOG => BLOB Fix code example Removed a leftover comma in security config sample ... Conflicts: reference/configuration/security.rst
weaverryan
added a commit
that referenced
this pull request
Jan 18, 2015
* 2.7: (31 commits) fix merge after removing @Security in 2.3 Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge) [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it Typo Fix: "allows to" should be "allows you to" Adding a link to log things in the prod environment [#4857] Adding missing word thanks to xabbuh move cautions to make them visible Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz language tweak thanks to xabbuh! Adding an example image of the debug_formatter [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix typo: BLOG => BLOB Fix code example Removed a leftover comma in security config sample ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.