Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherence in the intro paragraph between Doctrine and Propel #4349

Closed
arnaugm opened this issue Oct 20, 2014 · 5 comments
Closed

Incoherence in the intro paragraph between Doctrine and Propel #4349

arnaugm opened this issue Oct 20, 2014 · 5 comments

Comments

@arnaugm
Copy link

arnaugm commented Oct 20, 2014

In the introductory paragraphs of Doctrine and Propel we find the following sentences:

Fortunately, Symfony comes integrated with Doctrine.
Symfony does not come integrated with any ORMs but the Propel integration is easy.

It doesn't sound very coherent does it?

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2014

Well, both are true in some way. Actually, the full-stack framework doesn't ship with any ORM at all. But, when you are using the Symfony Standard Edition (and most people will start with it), you'll get Doctrine support "for free".

I agree with you that this doesn't sound very consistent though. Maybe we could reword the Doctrine part to something like

The Symfony full-stack framework doesn't integrate any ORM by default. Fortunately, the Symfony Standard Edition which you are using already comes integrated with Doctrine.

What do you think?

@arnaugm
Copy link
Author

arnaugm commented Oct 21, 2014

Yes I agree that both are true in some way, but if you read them toghether it's a bit confusing.
Your new proposal sounds much more clear. Should I create a pull request for it?

@xabbuh
Copy link
Member

xabbuh commented Oct 21, 2014

@arnaugm Go for it. We can then see what the others think about this and maybe adapt their thoughts if they have better wordings in mind.

weaverryan added a commit that referenced this issue Oct 29, 2014
…on paragraphs (arnaugm)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove incoherence between Doctrine and Propel introduction paragraphs

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4349

The introductory paragraph of Doctrine and Propel sections, although both are true in some way, look contradictory, so a rephrase of at least one of the two paragraphs would be convenient.

Commits
-------

7992fdf Remove incoherence between Doctrine and Propel introduction paragraphs
@arnaugm
Copy link
Author

arnaugm commented Oct 29, 2014

Thanks both, I'm happy to have my first contribution to the Symfony documentation! And I'm sure it won't be the last one.

@weaverryan
Copy link
Member

Congrats! Definitely don't let it be the last ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants