Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build.yml #112

Closed
wants to merge 2 commits into from
Closed

Create build.yml #112

wants to merge 2 commits into from

Conversation

stickyPiston
Copy link
Member

No description provided.

@stickyPiston stickyPiston marked this pull request as draft January 22, 2024 21:52
@stickyPiston stickyPiston self-assigned this Jan 22, 2024
@stickyPiston stickyPiston marked this pull request as ready for review January 22, 2024 22:50
@stickyPiston
Copy link
Member Author

This is a very rudimentary workflow that runs the linter, builds the application and saves the dist folder as an artefact. Before merging I still want to check whether there are some specifications sad-server requires for the artefact so that it can conveniently use it.

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Few nitpicks here. Also, could you merge main into this PR first?

@@ -11,7 +11,6 @@
<body>
<div id="root"></div>
<script type="module" src="/src/main.jsx"></script>
<script src="snow.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y no snow? :(

src/components/Activity.jsx Show resolved Hide resolved
@SilasPeters
Copy link
Member

Before merging I still want to check whether there are some specifications sad-server requires for the artefact so that it can conveniently use it.

Any updates on this?

@SilasPeters
Copy link
Member

@stickyPiston just reminding you that this PR has been reviewed

@SilasPeters
Copy link
Member

This might close #64

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge master, and I would approve this!

@stickyPiston stickyPiston marked this pull request as draft September 4, 2024 20:44
@stickyPiston stickyPiston deleted the radio-ci branch October 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants