-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build.yml #112
Create build.yml #112
Conversation
7f9e879
to
b6d00a7
Compare
This is a very rudimentary workflow that runs the linter, builds the application and saves the dist folder as an artefact. Before merging I still want to check whether there are some specifications sad-server requires for the artefact so that it can conveniently use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Few nitpicks here. Also, could you merge main into this PR first?
@@ -11,7 +11,6 @@ | |||
<body> | |||
<div id="root"></div> | |||
<script type="module" src="/src/main.jsx"></script> | |||
<script src="snow.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y no snow? :(
Any updates on this? |
@stickyPiston just reminding you that this PR has been reviewed |
This might close #64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge master, and I would approve this!
No description provided.