Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI #64

Closed
Riscky opened this issue Mar 18, 2020 · 4 comments
Closed

Set up CI #64

Riscky opened this issue Mar 18, 2020 · 4 comments
Labels
maintainability

Comments

@Riscky
Copy link
Member

Riscky commented Mar 18, 2020

We should set up a CircleCI instance to enforce eslint and check if the builds succeed.
Maybe we could even add some tests.
@Riscky
Copy link
Member Author

Riscky commented Mar 20, 2020

Or maybe CD to Netlify so PRs could be verified visually

@SilasPeters SilasPeters added enhancement Proposes (changes to) a feature maintainability and removed enhancement Proposes (changes to) a feature labels Oct 29, 2023
@SilasPeters SilasPeters mentioned this issue May 9, 2024
Closed
@SilasPeters
Copy link
Member

Reviving this issue haha. I understand that you are referring to the PR preview feature from Netlify, so that the resulting radio can be accessed from a temporary URL.

Why would we want this? Previewing it using npm run preview should suffice right?

@Riscky
Copy link
Member Author

Riscky commented May 15, 2024

Wow you're digging through the graveyard, aren't you? I guess I wanted a CI pipeline, and later also figured we could CD to netlify. Doesn't really seem to be worth it for this project though haha.

@SilasPeters
Copy link
Member

Alright thanks haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintainability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Riscky @SilasPeters