-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove yarn.lock and restore rc files #122
Conversation
0411773
to
d45de7c
Compare
I was told that we don't use babel anymore, but lot's of babel dependencies were still found. I don't understand react enough to judge if everything is alright now. |
db1fd8a
to
d92d6aa
Compare
We currently use two packagers: npm and yarn. This is bad, and I thus propose to switch to npm. Furthermore, in the vite PR we removed some .*rc files, which does not seem nessescary as far as I understand, and it would be better to keep them.
e0b5fd4
to
fcbca18
Compare
After talking to @josvanos , we solved everything! The babel linter and the linter jshint linter are no more, eslint now does everything. Lastly, we cleaned up lots of things, and added an editorconfig file. In another PR I will remove all warnings of the linter, and in a follow-up PR I will create a pipeline that tests if the linter passes. |
The CI pipeline proposal in #112 already includes a lint check before building: we simply need to merge this PR's branch into it to get that to work. |
As seen in the build.yml pull request, changing the lint command from 'eslint .' to 'eslint src' would be better. You can remove the ignore dist folder line in the eslintrc this way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
頑張った!
We currently use two packagers: npm and yarn. This is bad, and I thus propose to switch to npm.
Furthermore, in the vite PR we removed some .*rc files, which does not seem nessescary as far as I understand, and it would be better to keep them.
All linters seem to work, but see the other comments on why I am unsure to merge this.